From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S263415AbUE1PHw (ORCPT ); Fri, 28 May 2004 11:07:52 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S263419AbUE1PHw (ORCPT ); Fri, 28 May 2004 11:07:52 -0400 Received: from thunk.org ([140.239.227.29]:51942 "EHLO thunker.thunk.org") by vger.kernel.org with ESMTP id S263415AbUE1PHv (ORCPT ); Fri, 28 May 2004 11:07:51 -0400 Date: Fri, 28 May 2004 11:07:40 -0400 From: "Theodore Ts'o" To: Larry McVoy , "La Monte H.P. Yarroll" , Andrew Morton , Larry McVoy , linux-kernel@vger.kernel.org Subject: Re: [RFD] Explicitly documenting patch submission Message-ID: <20040528150740.GF18449@thunk.org> Mail-Followup-To: Theodore Ts'o , Larry McVoy , "La Monte H.P. Yarroll" , Andrew Morton , Larry McVoy , linux-kernel@vger.kernel.org References: <20040527062002.GA20872@work.bitmover.com> <20040527010409.66e76397.akpm@osdl.org> <40B6591C.80901@timesys.com> <20040527214638.GA18349@thunk.org> <20040528132436.GA11497@work.bitmover.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20040528132436.GA11497@work.bitmover.com> User-Agent: Mutt/1.5.6i Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org On Fri, May 28, 2004 at 06:24:36AM -0700, Larry McVoy wrote: > Not in any useful way. If I go look at the file history, which is what > I'm going to do when tracking down a bug, all I see on the files included > in this changeset is akpm@osdl.org. > > That means any annotated listing (BK or CVS blame) shows the wrong author. One of the ways that I often use for tracking down potential fixes is to simply do "bk changes > /tmp/foo" and then use emacs's incremental search to look for interesting potential changes. (I know, you're probably throwing up all over your keyboard just about now. :-) One "interesting" thing I've wished for is to be able to do "bk revtool drivers/net/wireless/airo.c", and then when I put my mouse over a particular line number, have it display in a little popup box the changelog description of whatever line my mouse happened to be over. It would be a real pain to try to implement that in tcl/Tk, though.... that would make it easier to solve the specific problem you've mentioned of "bk blame" showing the wrong author when looking at a particular source file. - Ted