[PATCH] report which device failed to suspend

[PATCH] report which device failed to suspend

[Nickolai Zeldovich]

When your machine stops suspending all of a sudden, a patch such as the
one below is helpful to diagnose which device or driver is misbehaving and
causing the suspend sequence to fail.

-- kolya

--- drivers/base/power/suspend.c	2004/05/27 22:09:47	1.1
+++ drivers/base/power/suspend.c	2004/05/27 22:28:36
@@ -42,6 +42,10 @@
 	if (dev->bus && dev->bus->suspend && !dev->power.power_state)
 		error = dev->bus->suspend(dev,state);

+	if (error)
+		printk(KERN_ERR "Could not suspend device %s: error %d\n",
+			kobject_name(&dev->kobj), error);
+
 	return error;
 }

Re: [PATCH] report which device failed to suspend

[Greg KH]

On Thu, May 27, 2004 at 06:36:16PM -0400, Nickolai Zeldovich wrote:
> When your machine stops suspending all of a sudden, a patch such as the
> one below is helpful to diagnose which device or driver is misbehaving and
> causing the suspend sequence to fail.
> 
> -- kolya
> 
> --- drivers/base/power/suspend.c	2004/05/27 22:09:47	1.1
> +++ drivers/base/power/suspend.c	2004/05/27 22:28:36
> @@ -42,6 +42,10 @@
>  	if (dev->bus && dev->bus->suspend && !dev->power.power_state)
>  		error = dev->bus->suspend(dev,state);
> 
> +	if (error)
> +		printk(KERN_ERR "Could not suspend device %s: error %d\n",
> +			kobject_name(&dev->kobj), error);
> +

As pointed out when Andrew forwarded this to me, this is the incorrect
way to do this, as -EAGAIN is valid to return from suspend().

I've put this check in the proper place in my trees.

thanks,

greg k-h