[PATCH] Lowered priority of "too many keys" message in atkbd

[PATCH] Lowered priority of "too many keys" message in atkbd

[Christoph Hellwig]

This patch is from the Debian kernel package and I think it's valid
because this error doesn't cause any kind of malfunction of the system.


--- linux/drivers/input/keyboard/atkbd.c	2004-04-05 19:49:28.000000000 +1000
+++ linux/drivers/input/keyboard/atkbd.c	2004-04-06 19:55:38.000000000 +1000
@@ -284,7 +284,7 @@
 			atkbd_report_key(&atkbd->dev, regs, KEY_HANJA, 3);
 			goto out;
 		case ATKBD_RET_ERR:
-			printk(KERN_WARNING "atkbd.c: Keyboard on %s reports too many keys pressed.\n", serio->phys);
+			printk(KERN_DEBUG "atkbd.c: Keyboard on %s reports too many keys pressed.\n", serio->phys);
 			goto out;
 	}
 

Re: [PATCH] Lowered priority of "too many keys" message in atkbd

[Pavel Machek]

Hi!

> This patch is from the Debian kernel package and I think it's valid
> because this error doesn't cause any kind of malfunction of the
> system.

Except perhaps dropped key?

When keypress is lost, I like to know if my fingers are to blame,
keyboard hardware is to blame, or keyboard is misdesigned.
								Pavel

> --- linux/drivers/input/keyboard/atkbd.c	2004-04-05 19:49:28.000000000 +1000
> +++ linux/drivers/input/keyboard/atkbd.c	2004-04-06 19:55:38.000000000 +1000
> @@ -284,7 +284,7 @@
>  			atkbd_report_key(&atkbd->dev, regs, KEY_HANJA, 3);
>  			goto out;
>  		case ATKBD_RET_ERR:
> -			printk(KERN_WARNING "atkbd.c: Keyboard on %s reports too many keys pressed.\n", serio->phys);
> +			printk(KERN_DEBUG "atkbd.c: Keyboard on %s reports too many keys pressed.\n", serio->phys);
>  			goto out;
>  	}
>  


-- 
934a471f20d6580d5aad759bf0d97ddc

Re: [PATCH] Lowered priority of "too many keys" message in atkbd

[Jörn Engel]

On Fri, 4 June 2004 14:48:11 +0200, Pavel Machek wrote:
> 
> > This patch is from the Debian kernel package and I think it's valid
> > because this error doesn't cause any kind of malfunction of the
> > system.
> 
> Except perhaps dropped key?
> 
> When keypress is lost, I like to know if my fingers are to blame,
> keyboard hardware is to blame, or keyboard is misdesigned.

And from experience I can tell, that lossy keyboards are a royal pain
in the behind.  And the system not doing *exactly* what I tell it to
do *is* a malfunction of the system.

"This is bad.  Do you really want to do it? (y/n)"

Just a single wrong key, eh!

Jörn

-- 
Fools ignore complexity.  Pragmatists suffer it.
Some can avoid it.  Geniuses remove it.
-- Perlis's Programming Proverb #58, SIGPLAN Notices, Sept.  1982