From: Adrian Bunk <bunk@fs.tum.de>
To: walt <wa1ter@myrealbox.com>, jgarzik@pobox.com
Cc: Linux Kernel <linux-kernel@vger.kernel.org>,
dth@ncc1701.cistron.net, linux-net@vger.kernel.org
Subject: [patch] Re: Gigabit Kconfig problems with yesterday's update
Date: Sun, 30 May 2004 15:45:45 +0200 [thread overview]
Message-ID: <20040530134544.GE13111@fs.tum.de> (raw)
In-Reply-To: <40B8A37D.1090802@myrealbox.com>
On Sat, May 29, 2004 at 07:51:41AM -0700, walt wrote:
> I have one machine with a gigabit NIC which I updated today from Linus'
> bk tree.
>
> The problem is that I was not asked if I wanted the 'new' gigabit
> support and therefore the tg3 support was dropped from my new .config.
>
> I edited .config by hand and deleted any mention of ethernet support --
> and only then did 'make oldconfig' ask me the right questions.
>
> Also: the phrase (10 or 100Mbit) should be deleted from the 'Ethernet'
> menu item since it implies (wrongly) that the item is not needed for
> gigabit support.
Thanks for this good report (and I'm now understanding the issue without
requiring your .config).
@Jeff:
At a first glance, it seems the patch below that simply removes the
dependency of NET_GIGE on NET_ETHERNET would suffice.
Is this correct or did I miss something?
> Thanks!
cu
Adrian
--- linux-2.6.7-rc2-full/drivers/net/Kconfig.old 2004-05-30 15:33:24.000000000 +0200
+++ linux-2.6.7-rc2-full/drivers/net/Kconfig 2004-05-30 15:38:41.000000000 +0200
@@ -1879,7 +1879,7 @@
config NET_GIGE
bool "Gigabit Ethernet (1000/10000 Mbit) controller support"
- depends on NETDEVICES && NET_ETHERNET && (PCI || SBUS)
+ depends on NETDEVICES && (PCI || SBUS)
help
Gigabit ethernet. It's yummy and fast, fast, fast.
next prev parent reply other threads:[~2004-05-30 13:46 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-05-29 14:51 Gigabit Kconfig problems with yesterday's update walt
2004-05-30 13:33 ` Adrian Bunk
2004-05-30 13:45 ` Adrian Bunk [this message]
2004-05-30 14:37 ` [patch] " Danny ter Haar
2004-05-30 16:41 ` Randy.Dunlap
2004-05-30 17:51 ` Jeff Garzik
2004-05-30 19:37 ` Adrian Bunk
2004-05-30 20:06 ` Linus Torvalds
2004-05-30 20:43 ` Jeff Garzik
2004-05-31 7:32 ` Christoph Hellwig
2004-05-31 10:00 ` Paul Mackerras
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040530134544.GE13111@fs.tum.de \
--to=bunk@fs.tum.de \
--cc=dth@ncc1701.cistron.net \
--cc=jgarzik@pobox.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-net@vger.kernel.org \
--cc=wa1ter@myrealbox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox