From: Pavel Machek <pavel@ucw.cz>
To: Arjan van de Ven <arjanv@redhat.com>
Cc: greg@kroah.com, linux-kernel@vger.kernel.org
Subject: Re: Resume enhancement: restore pci config space
Date: Sun, 30 May 2004 20:40:31 +0200 [thread overview]
Message-ID: <20040530184031.GF997@openzaurus.ucw.cz> (raw)
In-Reply-To: <20040526203524.GF2057@devserv.devel.redhat.com>
Hi!
> One can rightfully argue that the driver resume method should do this, and
> yes that is right. So the patch only does it for devices that don't have a
> resume method. Like the main PCI bridge on my testbox of which the bios so
> nicely forgets to restore the bus master bit during resume.. With this patch
> my testbox resumes just fine while it, well, wasn't all too happy as you can
> imagine without a busmaster pci bridge.
...
> +/*
> + * Default resume method for devices that have no driver provided resume,
> + * or not even a driver at all.
> + */
> +static void pci_default_resume(struct pci_dev *pci_dev)
> +{
Perhaps this should not be static so that drivers don't
need to duplicate this?
--
64 bytes from 195.113.31.123: icmp_seq=28 ttl=51 time=448769.1 ms
next prev parent reply other threads:[~2004-05-31 13:37 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-05-26 20:35 Resume enhancement: restore pci config space Arjan van de Ven
2004-05-26 22:39 ` Greg KH
2004-05-27 9:44 ` Takashi Iwai
2004-05-30 18:40 ` Pavel Machek [this message]
2004-05-31 13:38 ` Arjan van de Ven
2004-06-01 13:54 ` Takashi Iwai
2004-06-01 15:06 ` Arjan van de Ven
2004-06-01 15:26 ` Takashi Iwai
2004-06-01 15:38 ` Arjan van de Ven
2004-06-01 15:58 ` Takashi Iwai
2004-06-01 16:02 ` Pavel Machek
2004-06-01 16:18 ` Takashi Iwai
2004-05-31 16:38 ` Jan-Benedict Glaw
-- strict thread matches above, loose matches on Subject: below --
2004-05-26 21:44 Nakajima, Jun
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040530184031.GF997@openzaurus.ucw.cz \
--to=pavel@ucw.cz \
--cc=arjanv@redhat.com \
--cc=greg@kroah.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox