public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Stefan Seyfried <seife@suse.de>
To: Pavel Machek <pavel@suse.cz>
Cc: Andrew Morton <akpm@osdl.org>,
	ncunningham@linuxmail.org, cef-lkml@optusnet.com.au,
	linux-kernel@vger.kernel.org, rob@landley.net
Subject: Re: swappiness=0 makes software suspend fail.
Date: Mon, 31 May 2004 21:07:40 +0200	[thread overview]
Message-ID: <20040531190740.GA27310@suse.de> (raw)
In-Reply-To: <20040531115049.GB28188@atrey.karlin.mff.cuni.cz>

On Mon, May 31, 2004 at 01:50:49PM +0200, Pavel Machek wrote:

> I believe stefan has some script that fixes swap signature using dd if
> it detects suspend signature...

this is in boot.swap initscript:

check_swap_sig () {
    local part="$(get_swap_id)"
    local where what type rest p c
    while read  where what type rest ; do
        test "$type" = "swap" || continue
        c=continue
        for p in $part ; do
            test "$p" = "$where" && c=true
        done
        $c
        case "$(dd if=$where bs=1 count=6 skip=4086 2>/dev/null)" in
        S1SUSP|S2SUSP) mkswap $where
        esac
    done < /etc/fstab
}

so if the user passes "noresume", the boot scripts fix up the mess :-)
An unconditional "mkswap" on the swap partition is a not-so-good idea
unless you check the ID of the partition from the partition table since
mkswap will create swap on anything you give him which may not always
be what you wanted.

Anyway, i think it is not too bad doing such cleanup stuff in userspace.

-- 
Stefan Seyfried                     QA / R&D mobile devices, SUSE LINUX AG

"Any ideas, John?"
"Well, surrounding thems out."

  reply	other threads:[~2004-05-31 19:09 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-05-28  5:00 swappiness=0 makes software suspend fail Rob Landley
2004-05-28 21:56 ` Pavel Machek
2004-05-29  7:48   ` Nigel Cunningham
2004-05-29  9:05   ` Stuart Young
2004-05-29  8:56     ` Nigel Cunningham
2004-05-29 22:23       ` Pavel Machek
2004-05-31 10:09         ` Andrew Morton
2004-05-31 10:42           ` Nick Piggin
2004-05-31 10:17         ` Andrew Morton
2004-05-31 11:38           ` Rob Landley
2004-05-31 11:52             ` Pavel Machek
2004-06-01 10:46               ` Nigel Cunningham
2004-06-03 12:08                 ` Pavel Machek
2004-05-31 22:57             ` Flavio Stanchina
2004-06-04 12:20               ` Pavel Machek
2004-05-31 11:50           ` Pavel Machek
2004-05-31 19:07             ` Stefan Seyfried [this message]
2004-05-29 22:36       ` Pavel Machek
2004-05-30  2:21         ` Nick Piggin
2004-05-30 19:47           ` Pavel Machek
2004-05-30 23:23             ` Oliver Neukum
2004-05-31  3:28               ` Rob Landley
2004-05-31  6:18             ` Stuart Young
2004-05-31  8:41               ` Pavel Machek
2004-05-29 11:35     ` Pavel Machek

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20040531190740.GA27310@suse.de \
    --to=seife@suse.de \
    --cc=akpm@osdl.org \
    --cc=cef-lkml@optusnet.com.au \
    --cc=linux-kernel@vger.kernel.org \
    --cc=ncunningham@linuxmail.org \
    --cc=pavel@suse.cz \
    --cc=rob@landley.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox