Re: 2.6.7-rc2-mm1

Mikael Pettersson
2004-06-03T13:24:27Z

Joshua Kwan writes:
> On Tue, 01 Jun 2004 02:15:39 -0700, Andrew Morton wrote:
> > - merged perfctr. No documentation though :(
>
> In light of all of the problems with perfctr here, I've gone and done the
> ifdef work for CONFIG_PERFCTR, presenting an alternative solution to the
> struct problem...
>
> http://triplehelix.org/~joshk/perfctr.diff

What "all the problems"? There was an issue with warnings on
struct-declared-in-parameter-list when CONFIG_PERFCTR is disabled,
but those are trivial to fix and a fix was posted early on.

Your patch is #ifdef:ing out calls that have explicit no-op stubs
for the !CONFIG_PERFCTR_VIRTUAL case. This shouldn't be needed.
(And you're testing the wrong config option.)

Also _please_ include the maintainer of said code if you think
it has problems.

/Mikael