Re: intel-agp: skip non-AGP devices

Christoph Hellwig
2004-06-01T16:37:00Z

On Tue, Jun 01, 2004 at 11:04:57AM -0500, Matt Domsch wrote:
> Dave,
>
> On our PowerEdge 2600 system, which has an Intel E7501 Memroy
> Controller Hub, the intel-agp probe code is reporting, at KERN_ERR no less:
>
> agpgart: Unsupported Intel chipset (device id 254c)
>

...

> agp_intel_probe() calls pci_find_capability(PCI_CAP_ID_AGP)
> but doesn't check the return value (should be zero in this case) prior
> to moving into the switch.
>
>
> The patch below checks for a valid cap_ptr prior to printing the
> message, now at KERN_WARNING level (it's not really an error, is it?)

The real problem is that agpgart doesn't properly fill in the pci_id
table but claims all devices and then does it's own probing internally.

This also breaks hotplug in a funny way.