From: Greg KH <greg@kroah.com>
To: Tobias Weisserth <tobias@weisserth.org>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [Linux 2.6.4] EagleTec (rev 1.13) USB external harddisk support -> patch to unusual_devs.h
Date: Wed, 2 Jun 2004 13:33:07 -0700 [thread overview]
Message-ID: <20040602203307.GA19749@kroah.com> (raw)
In-Reply-To: <1086207977.8707.38.camel@coruscant.weisserth.net>
On Wed, Jun 02, 2004 at 10:26:18PM +0200, Tobias Weisserth wrote:
> Hi Greg,
>
> On Wed, 2004-06-02 at 20:21, Greg KH wrote:
> ...
> > I did that in the response I wrote above. Look in the Documentation
> > directory of the kernel source for the SubmittingPatches file...
>
> Stupid me. I didn't know until then that there is so much documentation
> already included with the kernel sources...
>
> > Good luck,
>
> Well, I hope I did this right.
>
> This is the patch:
>
> ######################################
>
> --- drivers/usb/storage/unusual_devs.h.orig 2004-06-02
> 21:53:18.292064768 +0200
> +++ drivers/usb/storage/unusual_devs.h 2004-06-02 22:00:39.486992944
> +0200
> @@ -409,6 +409,17 @@ UNUSUAL_DEV( 0x05e3, 0x0702, 0x0000, 0x
> US_SC_DEVICE, US_PR_DEVICE, NULL,
> US_FL_FIX_INQUIRY ),
>
> +/* Reported by Tobias Weisserth <tobias@weisserth.org>
> + * Some EagleTec devices don't work with the other entry for EagleTec.
> + * EagleTec devices with revision 1.13 like the "Pocket Boy" need a
> slight adjustment.
> + * That is the only reason this entry is needed.
> +*/
> +UNUSUAL_DEV( 0x05e3, 0x0702, 0x0113, 0x0113,
> + "EagleTec",
> + "External Hard Disk",
> + US_SC_DEVICE, US_PR_DEVICE, NULL,
> + US_FL_FIX_INQUIRY ),
> +
> /* Reported by Hanno Boeck <hanno@gmx.de>
> * Taken from the Lycoris Kernel */
> UNUSUAL_DEV( 0x0636, 0x0003, 0x0000, 0x9999,
>
> ######################################
>
> I hope there is no problem with the line wrapping and I did this
> right... first timer :-/
The patch got line-wrapped :(
Care to try it again?
> The patch applies to version 2.6.4 from www.kernel.org. It also works
> with Con Kolivas' sources version 2.6.4. I guess if all the symbols that
> are being used in the unit entry haven't disappeared from later kernel
> versions then it can be applied to later (or earlier) versions as well.
You might want to see if the patch is still needed on 2.6.6 as that is
the latest kernel. I need a diff against that kernel version.
thanks,
greg k-h
next prev parent reply other threads:[~2004-06-02 20:39 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1086086759.10599.14.camel@coruscant.weisserth.net>
[not found] ` <20040602165723.GI7829@kroah.com>
[not found] ` <1086200163.8709.8.camel@coruscant.weisserth.net>
[not found] ` <20040602182131.GA13193@kroah.com>
2004-06-02 20:26 ` [Linux 2.6.4] EagleTec (rev 1.13) USB external harddisk support -> patch to unusual_devs.h Tobias Weisserth
2004-06-02 20:33 ` Greg KH [this message]
2004-06-02 22:00 ` Tobias Weisserth
2004-06-02 22:59 ` Greg KH
2004-06-05 17:14 ` Tobias Weisserth
2004-06-14 21:40 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040602203307.GA19749@kroah.com \
--to=greg@kroah.com \
--cc=linux-kernel@vger.kernel.org \
--cc=tobias@weisserth.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox