[Linux 2.6.4] EagleTec (rev 1.13) USB external harddisk support -> patch to unusual_devs.h

[Linux 2.6.4] EagleTec (rev 1.13) USB external harddisk support -> patch to unusual_devs.h

[Tobias Weisserth]

Hi Greg,

On Wed, 2004-06-02 at 20:21, Greg KH wrote:
...
> I did that in the response I wrote above.  Look in the Documentation
> directory of the kernel source for the SubmittingPatches file...

Stupid me. I didn't know until then that there is so much documentation
already included with the kernel sources...

> Good luck,

Well, I hope I did this right.

This is the patch:

######################################

--- drivers/usb/storage/unusual_devs.h.orig	2004-06-02
21:53:18.292064768 +0200
+++ drivers/usb/storage/unusual_devs.h	2004-06-02 22:00:39.486992944
+0200
@@ -409,6 +409,17 @@ UNUSUAL_DEV(  0x05e3, 0x0702, 0x0000, 0x
 		US_SC_DEVICE, US_PR_DEVICE, NULL,
 		US_FL_FIX_INQUIRY ),
 
+/* Reported by Tobias Weisserth <tobias@weisserth.org>
+ * Some EagleTec devices don't work with the other entry for EagleTec. 
+ * EagleTec devices with revision 1.13 like the "Pocket Boy" need a
slight adjustment.
+ * That is the only reason this entry is needed.
+*/
+UNUSUAL_DEV(  0x05e3, 0x0702, 0x0113, 0x0113,
+                "EagleTec",
+                "External Hard Disk",
+                US_SC_DEVICE, US_PR_DEVICE, NULL,
+                US_FL_FIX_INQUIRY ),
+
 /* Reported by Hanno Boeck <hanno@gmx.de>
  * Taken from the Lycoris Kernel */
 UNUSUAL_DEV(  0x0636, 0x0003, 0x0000, 0x9999,

######################################

I hope there is no problem with the line wrapping and I did this
right... first timer :-/

The patch applies to version 2.6.4 from www.kernel.org. It also works
with Con Kolivas' sources version 2.6.4. I guess if all the symbols that
are being used in the unit entry haven't disappeared from later kernel
versions then it can be applied to later (or earlier) versions as well.

The device I'm using wouldn't work without this modification. It didn't
show up in /dev but I could read the Vendor ID in "usbview" and this led
me to a very old entry in Red Hat bugzilla:
http://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=80328

Seeing that there already was an entry in
drivers/usb/storage/unusual_devs.h for EagleTec I only changed the bit
for the firmware version and it seems to work just fine.

Testing: I have successfully mounted a fat32 drive and read, deleted and
written (modified) files after applying my changes to the kernel.

Since this device seems to be very popular in Germany due a recent
catalogue offer from www.pearl.de for less than 10€ I guess a great deal
of users would benefit from the addition. The "Pocket Boy" I own is a
USB 1.1 device. There is a similar device from the same vendor with USB
2.0 that is also called "Pocket Boy". I don't have one though so I don't
know what kind of chipset it is depending on.

I hope this information is conforming to submitting standards. Please
feel free to correct me on any mistakes I made.

regards,
Tobias Weisserth

Re: [Linux 2.6.4] EagleTec (rev 1.13) USB external harddisk support -> patch to unusual_devs.h

[Greg KH]

On Wed, Jun 02, 2004 at 10:26:18PM +0200, Tobias Weisserth wrote:
> Hi Greg,
> 
> On Wed, 2004-06-02 at 20:21, Greg KH wrote:
> ...
> > I did that in the response I wrote above.  Look in the Documentation
> > directory of the kernel source for the SubmittingPatches file...
> 
> Stupid me. I didn't know until then that there is so much documentation
> already included with the kernel sources...
> 
> > Good luck,
> 
> Well, I hope I did this right.
> 
> This is the patch:
> 
> ######################################
> 
> --- drivers/usb/storage/unusual_devs.h.orig	2004-06-02
> 21:53:18.292064768 +0200
> +++ drivers/usb/storage/unusual_devs.h	2004-06-02 22:00:39.486992944
> +0200
> @@ -409,6 +409,17 @@ UNUSUAL_DEV(  0x05e3, 0x0702, 0x0000, 0x
>  		US_SC_DEVICE, US_PR_DEVICE, NULL,
>  		US_FL_FIX_INQUIRY ),
>  
> +/* Reported by Tobias Weisserth <tobias@weisserth.org>
> + * Some EagleTec devices don't work with the other entry for EagleTec. 
> + * EagleTec devices with revision 1.13 like the "Pocket Boy" need a
> slight adjustment.
> + * That is the only reason this entry is needed.
> +*/
> +UNUSUAL_DEV(  0x05e3, 0x0702, 0x0113, 0x0113,
> +                "EagleTec",
> +                "External Hard Disk",
> +                US_SC_DEVICE, US_PR_DEVICE, NULL,
> +                US_FL_FIX_INQUIRY ),
> +
>  /* Reported by Hanno Boeck <hanno@gmx.de>
>   * Taken from the Lycoris Kernel */
>  UNUSUAL_DEV(  0x0636, 0x0003, 0x0000, 0x9999,
> 
> ######################################
> 
> I hope there is no problem with the line wrapping and I did this
> right... first timer :-/

The patch got line-wrapped :(

Care to try it again?

> The patch applies to version 2.6.4 from www.kernel.org. It also works
> with Con Kolivas' sources version 2.6.4. I guess if all the symbols that
> are being used in the unit entry haven't disappeared from later kernel
> versions then it can be applied to later (or earlier) versions as well.

You might want to see if the patch is still needed on 2.6.6 as that is
the latest kernel.  I need a diff against that kernel version.

thanks,

greg k-h

Re: [Linux 2.6.4] EagleTec (rev 1.13) USB external harddisk support -> patch to unusual_devs.h

[Tobias Weisserth]

Hi Greg,

On Wed, 2004-06-02 at 22:33, Greg KH wrote:
...
> The patch got line-wrapped :(

Darn Evolution.

OK. Let's try again:

############################

--- drivers/usb/storage/unusual_devs.h.orig	2004-06-02
21:53:18.292064768 +0200
+++ drivers/usb/storage/unusual_devs.h	2004-06-02 22:00:39.486992944
+0200
@@ -409,6 +409,17 @@ UNUSUAL_DEV(  0x05e3, 0x0702, 0x0000, 0x
 		US_SC_DEVICE, US_PR_DEVICE, NULL,
 		US_FL_FIX_INQUIRY ),
 
+/* Reported by Tobias Weisserth <tobias@weisserth.org>
+ * Some EagleTec devices don't work with the other 
+ * entry for EagleTec. EagleTec devices with
+ * revision 1.13 like the "Pocket Boy" 
+ * need a slight adjustment.
+ * That is the only reason this entry is needed.
+*/
+UNUSUAL_DEV(  0x05e3, 0x0702, 0x0113, 0x0113,
+                "EagleTec",
+                "External Hard Disk",
+                US_SC_DEVICE, US_PR_DEVICE, NULL,
+                US_FL_FIX_INQUIRY ),
+
 /* Reported by Hanno Boeck <hanno@gmx.de>
  * Taken from the Lycoris Kernel */
 UNUSUAL_DEV(  0x0636, 0x0003, 0x0000, 0x9999,

########################

> Care to try it again?

Sure. But the first line seems to be wrapped already on my screen :-(

This time I inserted the content directly from the text file and not the
clipboard. I don't know whether this makes a difference though.
Evolution doesn't have an option to set the number of characters per
line or I'm just too stupid to find it :-(

In case this gets screwed too, might I consider sending it along as a
text attachment?

> > The patch applies to version 2.6.4 from www.kernel.org. It also works
> > with Con Kolivas' sources version 2.6.4. I guess if all the symbols that
> > are being used in the unit entry haven't disappeared from later kernel
> > versions then it can be applied to later (or earlier) versions as well.
> 
> You might want to see if the patch is still needed on 2.6.6 as that is
> the latest kernel.  I need a diff against that kernel version.

Now I have a problem. 2.6.6 won't run with the same .config as 2.6.4
after running "make oldconfig" on my system for some reason. I haven't
found out yet why. It boots but when it comes to the part where it goes
through the IDE devices it stops with some kind of driveSeekError and
panics.

I've taken a look into drivers/usb/storage/unusual_devs.h from 2.6.6 and
I noticed that the EagleTec entry from 2.6.4 has disappeared completely.

There's this though:

UNUSUAL_DEV(  0x05e3, 0x0702, 0x0000, 0xffff,
                "Genesys Logic",
                "USB to IDE Disk",
                US_SC_DEVICE, US_PR_DEVICE, NULL,
                US_FL_FIX_INQUIRY ),

It uses the same vendor ID and is completely identical to the original
EagleTec entry in 2.6.4 and might just work by changing "0x0000,
0xffff," to "0x0113, 0x0113,". I can't confirm though without a working
2.6.6 kernel but it *should* work like this since if the Genesys Logic
entry is still inside unusual_devs.h for the reason the comment states,
the same *should* apply to my EagleTec device with the same vendor ID as
the original EagleTec entry is just a duplicate of this one, including
the comment.

I can make these changes to 2.6.6 for now and create a diff output, run
make to see whether it compiles but I can't test it. Does this help?

I'll try to sort out my 2.6.6 issues on Monday as I have an exam on
Friday and one on Monday. After those my mind is free for solving kernel
issues :-/

kind regards,
Tobias Weisserth

Re: [Linux 2.6.4] EagleTec (rev 1.13) USB external harddisk support -> patch to unusual_devs.h

[Greg KH]

On Thu, Jun 03, 2004 at 12:00:10AM +0200, Tobias Weisserth wrote:
> Hi Greg,
> 
> On Wed, 2004-06-02 at 22:33, Greg KH wrote:
> ...
> > The patch got line-wrapped :(
> 
> Darn Evolution.
> 
> OK. Let's try again:

Nope, sorry.  Don't cut and paste.  Try attaching as a text attachment,
or doing something with your editor to read from your patch file into
the body of the email.

thanks,

greg k-h

Re: [Linux 2.6.4] EagleTec (rev 1.13) USB external harddisk support -> patch to unusual_devs.h

[Tobias Weisserth]

[-- Attachment #1: Type: text/plain, Size: 1172 bytes --]

Hi,

On Thu, 2004-06-03 at 00:59, Greg KH wrote:
...
> Nope, sorry.  Don't cut and paste.  Try attaching as a text attachment,
> or doing something with your editor to read from your patch file into
> the body of the email.

I tried the latter. Doesn't seem to work.

I attached the patches.

Those are a patch for the 2.6.6 kernel and the 2.6.4 kernel.

When I was going through all my kernel branches in /usr/src I noticed
that the Gentoo development branch already had a suitable entry for the
firmware version of my device:

/* Reported by Henning Schild <henning@wh9.tu-dresden.de> */
UNUSUAL_DEV(  0x05e3, 0x0702, 0x0113, 0x0113,
                "EagleTec",
                "External Hard Disk",
                US_SC_DEVICE, US_PR_DEVICE, NULL,
                US_FL_FIX_INQUIRY ),

More information on these sources:

http://packages.gentoo.org/ebuilds/?gentoo-dev-sources-2.6.5-r1

I found it in no other branch besides this.

So if you include my patch then you might consider putting his name
there too. I discovered his entry after I figured out by myself how to
make EagleTec revision 1.13 work, but I don't know whether he did it
before me.

regards,
Tobias

[-- Attachment #2: patch-EagleTec113-2.6.4 --]
[-- Type: text/plain, Size: 942 bytes --]

--- drivers/usb/storage/unusual_devs.h.orig	2004-06-02 21:53:18.000000000 +0200
+++ drivers/usb/storage/unusual_devs.h	2004-06-05 19:04:10.880021976 +0200
@@ -409,6 +409,20 @@ UNUSUAL_DEV(  0x05e3, 0x0702, 0x0000, 0x
 		US_SC_DEVICE, US_PR_DEVICE, NULL,
 		US_FL_FIX_INQUIRY ),
 
+/* Reported by Tobias Weisserth <tobias@weisserth.org>
+ * Like the SIIG unit above, this unit needs an INQUIRY to ask for exactly
+ * 36 bytes of data.  No more, no less. That is the only reason this entry
+ * is needed.
+ *
+ * This entry is an exact copy of the above entry with a different
+ * firmware revision (1.13).
+*/
+UNUSUAL_DEV(  0x05e3, 0x0702, 0x0113, 0x0113,
+                "EagleTec",
+                "External Hard Disk",
+                US_SC_DEVICE, US_PR_DEVICE, NULL,
+                US_FL_FIX_INQUIRY ),
+
 /* Reported by Hanno Boeck <hanno@gmx.de>
  * Taken from the Lycoris Kernel */
 UNUSUAL_DEV(  0x0636, 0x0003, 0x0000, 0x9999,

[-- Attachment #3: patch-EagleTec113-2.6.6 --]
[-- Type: text/plain, Size: 942 bytes --]

--- drivers/usb/storage/unusual_devs.h.orig	2004-06-05 18:59:00.932141216 +0200
+++ drivers/usb/storage/unusual_devs.h	2004-06-05 19:01:22.818571200 +0200
@@ -417,6 +417,20 @@ UNUSUAL_DEV(  0x05e3, 0x0702, 0x0000, 0x
 		US_SC_DEVICE, US_PR_DEVICE, NULL,
 		US_FL_FIX_INQUIRY ),
 
+/* Reported by Tobias Weisserth <tobias@weisserth.org>
+ * Like the SIIG unit above, this unit needs an INQUIRY to ask for exactly
+ * 36 bytes of data.  No more, no less. That is the only reason this entry
+ * is needed.
+ *
+ * This entry is an exact copy of the above entry with a different
+ * firmware revision (1.13).
+*/
+UNUSUAL_DEV(  0x05e3, 0x0702, 0x0113, 0x0113,
+                "EagleTec",
+                "External Hard Disk",
+                US_SC_DEVICE, US_PR_DEVICE, NULL,
+                US_FL_FIX_INQUIRY ),
+
 /* Reported by Hanno Boeck <hanno@gmx.de>
  * Taken from the Lycoris Kernel */
 UNUSUAL_DEV(  0x0636, 0x0003, 0x0000, 0x9999,

Re: [Linux 2.6.4] EagleTec (rev 1.13) USB external harddisk support -> patch to unusual_devs.h

[Greg KH]

On Sat, Jun 05, 2004 at 07:14:23PM +0200, Tobias Weisserth wrote:
> Hi,
> 
> On Thu, 2004-06-03 at 00:59, Greg KH wrote:
> ...
> > Nope, sorry.  Don't cut and paste.  Try attaching as a text attachment,
> > or doing something with your editor to read from your patch file into
> > the body of the email.
> 
> I tried the latter. Doesn't seem to work.
> 
> I attached the patches.
> 
> Those are a patch for the 2.6.6 kernel and the 2.6.4 kernel.
> 
> When I was going through all my kernel branches in /usr/src I noticed
> that the Gentoo development branch already had a suitable entry for the
> firmware version of my device:
> 
> /* Reported by Henning Schild <henning@wh9.tu-dresden.de> */
> UNUSUAL_DEV(  0x05e3, 0x0702, 0x0113, 0x0113,
>                 "EagleTec",
>                 "External Hard Disk",
>                 US_SC_DEVICE, US_PR_DEVICE, NULL,
>                 US_FL_FIX_INQUIRY ),
> 
> More information on these sources:
> 
> http://packages.gentoo.org/ebuilds/?gentoo-dev-sources-2.6.5-r1
> 
> I found it in no other branch besides this.
> 
> So if you include my patch then you might consider putting his name
> there too. I discovered his entry after I figured out by myself how to
> make EagleTec revision 1.13 work, but I don't know whether he did it
> before me.

Hm, this is already fixed in the current kernel trees, so your patch
should not be needed.

thanks,

greg k-h