From: Jens Axboe <axboe@suse.de>
To: "Jeff V. Merkey" <jmerkey@drdos.com>
Cc: linux-kernel@vger.kernel.org
Subject: Re: submit_bh leaves interrupts on upon return
Date: Thu, 3 Jun 2004 10:50:03 +0200 [thread overview]
Message-ID: <20040603085002.GG28915@suse.de> (raw)
In-Reply-To: <40BE93DC.6040501@drdos.com>
On Wed, Jun 02 2004, Jeff V. Merkey wrote:
>
> Any reason why submit_bh should turn on interrupts after being called by
> a process with ints off in 2.4.20? I see it's possible to sleep during
> elevatoring, but why does it need to leave interrupts on if the calling
> state was with ints off.
It's illegal to call it with interrupts off, so... __make_request()
doesn't save interrupt state, so you will always leave with interrupts
enabled.
--
Jens Axboe
next prev parent reply other threads:[~2004-06-03 8:50 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-06-03 2:58 submit_bh leaves interrupts on upon return Jeff V. Merkey
2004-06-03 8:50 ` Jens Axboe [this message]
2004-06-03 20:46 ` Jeff V. Merkey
2004-06-03 16:52 ` Jens Axboe
2004-06-03 20:59 ` Jeff V. Merkey
2004-06-03 17:03 ` Jens Axboe
2004-06-03 17:26 ` Linus Torvalds
2004-06-03 17:34 ` Jens Axboe
2004-06-03 23:56 ` Jeff V. Merkey
2004-06-03 21:17 ` Jeff V. Merkey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040603085002.GG28915@suse.de \
--to=axboe@suse.de \
--cc=jmerkey@drdos.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox