public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Pavel Machek <pavel@ucw.cz>
To: Paul Clements <paul.clements@steeleye.com>
Cc: akpm@osdl.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] nbd: fix device names
Date: Thu, 3 Jun 2004 15:44:41 +0200	[thread overview]
Message-ID: <20040603134440.GC3915@openzaurus.ucw.cz> (raw)
In-Reply-To: <40BC8C49.4020602@steeleye.com>

Hi!

> It seems more appropriate to call the devices "nbX" rather than 
> "nbdX",
> since that's what the device nodes are actually named.

> @@ -713,7 +753,7 @@ static int __init nbd_init(void)
>  		disk->fops = &nbd_fops;
>  		disk->private_data = &nbd_dev[i];
>  		disk->flags |= GENHD_FL_SUPPRESS_PARTITION_INFO;
> -		sprintf(disk->disk_name, "nbd%d", i);
> +		sprintf(disk->disk_name, "nb%d", i);
>  		sprintf(disk->devfs_name, "nbd/%d", i);

You might want to fix devfs name, too.


-- 
64 bytes from 195.113.31.123: icmp_seq=28 ttl=51 time=448769.1 ms         


      parent reply	other threads:[~2004-06-03 13:45 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-02-19 18:17 [PATCH 2/2] nbd: remove PARANOIA and other cleanups Paul Clements
2004-06-01 14:01 ` [PATCH] nbd: fix device names Paul Clements
2004-06-01 23:32   ` Andrew Morton
2004-06-02  3:06     ` Paul Clements
2004-06-03 13:44   ` Pavel Machek [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20040603134440.GC3915@openzaurus.ucw.cz \
    --to=pavel@ucw.cz \
    --cc=akpm@osdl.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=paul.clements@steeleye.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox