public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Russell King <rmk+lkml@arm.linux.org.uk>
To: Christoph Hellwig <hch@infradead.org>,
	Linux Kernel List <linux-kernel@vger.kernel.org>,
	Andrew Morton <akpm@osdl.org>, Linus Torvalds <torvalds@osdl.org>
Subject: Re: Export swapper_space
Date: Thu, 3 Jun 2004 17:01:37 +0100	[thread overview]
Message-ID: <20040603170137.E8244@flint.arm.linux.org.uk> (raw)
In-Reply-To: <20040603153727.GA17798@infradead.org>; from hch@infradead.org on Thu, Jun 03, 2004 at 04:37:27PM +0100

On Thu, Jun 03, 2004 at 04:37:27PM +0100, Christoph Hellwig wrote:
> On Thu, Jun 03, 2004 at 04:19:10PM +0100, Russell King wrote:
> > swapper_space appears to be needed by modules:
> > 
> >   Building modules, stage 2.
> >   MODPOST
> > *** Warning: "swapper_space" [drivers/block/loop.ko] undefined!
> > *** Warning: "swapper_space" [drivers/scsi/st.ko] undefined!
> > *** Warning: "swapper_space" [drivers/scsi/sg.ko] undefined!
> 
> Please not.  This seems to be some cache-flushing magic on the stranger
> architectures again :)  Can you check how they're using it in the end
> and hopefully fix it by uninlining something?

extern struct address_space swapper_space;
static inline struct address_space *page_mapping(struct page *page)
{
        struct address_space *mapping = NULL;
 
        if (unlikely(PageSwapCache(page)))
                mapping = &swapper_space;
        else if (likely(!PageAnon(page)))
                mapping = page->mapping;
        return mapping;
}

I'll leave that for someone else to sort out.

-- 
Russell King
 Linux kernel    2.6 ARM Linux   - http://www.arm.linux.org.uk/
 maintainer of:  2.6 PCMCIA      - http://pcmcia.arm.linux.org.uk/
                 2.6 Serial core

  reply	other threads:[~2004-06-03 16:02 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-06-03 15:19 Export swapper_space Russell King
2004-06-03 15:37 ` Christoph Hellwig
2004-06-03 16:01   ` Russell King [this message]
2004-06-03 17:08     ` Andrew Morton
2004-06-03 17:21       ` Russell King

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20040603170137.E8244@flint.arm.linux.org.uk \
    --to=rmk+lkml@arm.linux.org.uk \
    --cc=akpm@osdl.org \
    --cc=hch@infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=torvalds@osdl.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox