Re: [PATCH 2.6.6-rc2 RFT] Add's class support to cpuid.c

Greg KH
2004-06-03T19:37:13Z

On Wed, Jun 02, 2004 at 05:11:21PM -0700, H. Peter Anvin wrote:
> Hanna Linder wrote:
> >This patch adds class support to arch/i386/kernel/cpuid.c. This enables
> >udev
> >support. I have tested on a 2-way SMP system and on a 2-way built as UP.
> >Here are the results for the SMP:
>
> I think it would be better if udev could handle /dev/cpu as an iterator
> instead of needing O(N) kernel memory for all per-CPU devices; I made the
> same comments about devfs.

Sorry, but that's not going to happen at this time.

> As it is, it also mishandles the hotswap CPU scenario.

I agree, but that can be easily added with a second patch on top of this
one, right Hanna? :)

I'll go add this to the driver-2.6 bk tree to show up in the next -mm.

thanks,

greg k-h