Re: [PATCH] cpumask 5/10 rewrite cpumask.h - single bitmap based implementation

William Lee Irwin III
2004-06-04T11:28:08Z

William Lee Irwin III writes:
>> cpumask_scnprintf() is correct to all appearances... testcase please.

On Fri, Jun 04, 2004 at 01:16:35PM +0200, Mikael Pettersson wrote:
> How large buf does it need? I don't see any spec for that in 2.6.6.
> Second, let's just say that while some kernel people think that
> converting stuff to ASCII is "neat", I'm not one of them. It's
> just a waste of time and space, for both kernel and user-space.
> I'd rather do a for-each-CPU loop which strictly keeps to cpumask_t
> operations than take a detour via ASCII.

If you care to export an architecture-neutral and/or 32/64 -bit
compatible binary representation of a bitmap, please provide the
implementation in lib/bitmap.c; I'm relatively agnostic on the ASCII
vs. whatever issue. Others may not be...

The cpu count for cpumask_t should be visible to userspace as the
dreaded sysconf(_SC_NPROCESSORS_CONF)... don't ask how this is
implemented, you don't want to know.

Thanks.

-- wli