Re: [PATCH] cpumask 5/10 rewrite cpumask.h - single bitmap based implementation

Rusty Russell
2004-06-04T02:20:02Z

On Fri, 2004-06-04 at 12:02, Nick Piggin wrote:
> Rusty Russell wrote:
> > So, opinion alert: if I were doing this, I'd probably live without this
> > macro; in my mind it crosses the "too much abstraction" line. I did
> > momentarily wonder what this macro did when I saw it used in the
> > succeeding patches.
>
> I think if you don't like that abstraction, there should be no
> cpumask type at all, just use the bitmap.
>
> I don't see what you gain from having the cpumask type but having
> to get at its internals with the bitop functions.

Yes, that was the previous debate to which I alluded, although having a
separate type helps make typesafe functions.

But to clarify: my question here was over the cpu_addr() macro.

Rusty.
--
Anyone who quotes me in their signature is an idiot -- Rusty Russell