public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Pavel Machek <pavel@suse.cz>
To: Christoph Hellwig <hch@ucw.cz>,
	vojtech@suse.cz, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Lowered priority of "too many keys" message in atkbd
Date: Fri, 4 Jun 2004 14:48:11 +0200	[thread overview]
Message-ID: <20040604124811.GC11950@elf.ucw.cz> (raw)
In-Reply-To: <20040530083126.GA30916@lst.de>

Hi!

> This patch is from the Debian kernel package and I think it's valid
> because this error doesn't cause any kind of malfunction of the
> system.

Except perhaps dropped key?

When keypress is lost, I like to know if my fingers are to blame,
keyboard hardware is to blame, or keyboard is misdesigned.
								Pavel

> --- linux/drivers/input/keyboard/atkbd.c	2004-04-05 19:49:28.000000000 +1000
> +++ linux/drivers/input/keyboard/atkbd.c	2004-04-06 19:55:38.000000000 +1000
> @@ -284,7 +284,7 @@
>  			atkbd_report_key(&atkbd->dev, regs, KEY_HANJA, 3);
>  			goto out;
>  		case ATKBD_RET_ERR:
> -			printk(KERN_WARNING "atkbd.c: Keyboard on %s reports too many keys pressed.\n", serio->phys);
> +			printk(KERN_DEBUG "atkbd.c: Keyboard on %s reports too many keys pressed.\n", serio->phys);
>  			goto out;
>  	}
>  


-- 
934a471f20d6580d5aad759bf0d97ddc

  reply	other threads:[~2004-06-04 12:48 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-05-30  8:31 [PATCH] Lowered priority of "too many keys" message in atkbd Christoph Hellwig
2004-06-04 12:48 ` Pavel Machek [this message]
2004-06-04 13:08   ` Jörn Engel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20040604124811.GC11950@elf.ucw.cz \
    --to=pavel@suse.cz \
    --cc=hch@ucw.cz \
    --cc=linux-kernel@vger.kernel.org \
    --cc=vojtech@suse.cz \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox