From: Greg KH <greg@kroah.com>
To: Andrew Zabolotny <zap@homelink.ru>,
Todd Poynor <tpoynor@mvista.com>,
linux-kernel@vger.kernel.org
Subject: Re: two patches - request for comments
Date: Fri, 4 Jun 2004 13:43:22 -0700 [thread overview]
Message-ID: <20040604204322.GA13569@kroah.com> (raw)
In-Reply-To: <20040602223219.B9322@flint.arm.linux.org.uk>
On Wed, Jun 02, 2004 at 10:32:19PM +0100, Russell King wrote:
> On Wed, Jun 02, 2004 at 10:15:42AM -0700, Greg KH wrote:
> > On Wed, Jun 02, 2004 at 01:00:36AM +0400, Andrew Zabolotny wrote:
> > >
> > > In theory, if we would use the standard power interface, it could use the
> > > different levels of power saving, e.g. 0 - controller and LCD on, 1,2 - LCD
> > > off, controller on, 3,4 - both off.
> >
> > Please use the standard power interface, and use the standard levels of
> > power state. That's why we _have_ this driver model in the first
> > place...
>
> It /doesn't/ make any sense to in this case. We're talking effectively
> about the LCD panel attributes, not a device as such.
<snip>
> Hope this provides some extra reasoning why using the device model
> for these attributes is wrong.
Ok, this makes more sense now, thanks for explaining it.
greg k-h
next prev parent reply other threads:[~2004-06-04 22:48 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-05-28 21:20 two patches - request for comments Andrew Zabolotny
2004-05-28 21:59 ` Todd Poynor
2004-05-29 8:10 ` Andrew Zabolotny
2004-06-01 20:09 ` Todd Poynor
2004-06-01 21:00 ` Andrew Zabolotny
2004-06-02 17:15 ` Greg KH
2004-06-02 21:25 ` Andrew Zabolotny
2004-06-02 21:32 ` Russell King
2004-06-04 20:43 ` Greg KH [this message]
2004-05-28 22:10 ` Greg KH
2004-05-29 8:44 ` Andrew Zabolotny
2004-06-01 21:23 ` Jeff Garzik
2004-06-01 21:57 ` Andrew Zabolotny
2004-06-02 17:12 ` Greg KH
2004-05-29 13:46 ` Denis Vlasenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040604204322.GA13569@kroah.com \
--to=greg@kroah.com \
--cc=linux-kernel@vger.kernel.org \
--cc=tpoynor@mvista.com \
--cc=zap@homelink.ru \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox