From: Greg KH <greg@kroah.com>
To: "Frank A. Uepping" <Frank.A.Uepping@t-online.de>
Cc: linux-kernel@vger.kernel.org, Patrick Mochel <mochel@digitalimplant.org>
Subject: Re: struct device::release issue
Date: Fri, 4 Jun 2004 14:52:23 -0700 [thread overview]
Message-ID: <20040604215223.GC13825@kroah.com> (raw)
In-Reply-To: <200403271526.25505.Frank.A.Uepping@t-online.de>
On Sat, Mar 27, 2004 at 03:26:25PM +0100, Frank A. Uepping wrote:
> On Saturday 27 March 2004 02:14, Greg KH wrote:
> > On Sat, Mar 06, 2004 at 12:47:24PM +0100, Frank A. Uepping wrote:
> > > Hi,
> > > if device_add fails (e.g. bus_add_device returns an error) then the release
> > > method will be called for the device. Is this a bug or a feature?
> >
> > Are you sure this will happen? device_initialize() gets a reference
> > that is still present after device_add() fails, right? So release()
> > will not get called.
> At the label PMError, kobject_unregister is called, which decrements the
> recount by 2, which will result in calling release at label Done (put_device).
>
> kobject_unregister should be superseded by kobject_del.
> Here is a patch:
Sorry for the long delay. You are correct, I've applied this patch. It
will show up in the next -mm release and will go to Linus after 2.6.7 is
out.
thanks,
greg k-h
prev parent reply other threads:[~2004-06-04 22:48 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-03-06 11:47 struct device::release issue Frank A. Uepping
2004-03-27 1:14 ` Greg KH
2004-03-27 14:26 ` Frank A. Uepping
2004-06-04 21:52 ` Greg KH [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040604215223.GC13825@kroah.com \
--to=greg@kroah.com \
--cc=Frank.A.Uepping@t-online.de \
--cc=linux-kernel@vger.kernel.org \
--cc=mochel@digitalimplant.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox