public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: viro@parcelfarce.linux.theplanet.co.uk
To: linux-kernel@vger.kernel.org
Cc: perex@suse.cz, torvalds@osdl.org
Subject: Re: [RFC] ASLA design, depth of code review and lack thereof
Date: Sat, 5 Jun 2004 00:14:56 +0100	[thread overview]
Message-ID: <20040604231456.GS12308@parcelfarce.linux.theplanet.co.uk> (raw)
In-Reply-To: <20040604230819.GR12308@parcelfarce.linux.theplanet.co.uk>

On Sat, Jun 05, 2004 at 12:08:19AM +0100, viro@parcelfarce.linux.theplanet.co.uk wrote:
> Ladies and gentlemen, may I politely ask what description would fit somebody
> who have made the following
> 
>         case SNDRV_PCM_FORMAT_FLOAT_BE:
>         {
>                 union {
>                         float f;
>                         u_int32_t i;
>                 } u;
>                 u.f = 0.0;
> #ifdef SNDRV_LITTLE_ENDIAN
>                 return bswap_32(u.i);
> #else
>                 return u.i;
> #endif
>         }
> and quite a few similar, er, wonders an ioctl?

... immediately followed by a self-LART - it's still an ugly code, all
right, but that's not an ioctl.

My apologies to everyone.

  reply	other threads:[~2004-06-04 23:22 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-06-04 23:08 [RFC] ASLA design, depth of code review and lack thereof viro
2004-06-04 23:14 ` viro [this message]
2004-06-04 23:29 ` Linus Torvalds
2004-06-05  0:04   ` viro
2004-06-07 13:14     ` Takashi Iwai
2004-06-07 22:40       ` viro
2004-06-08 12:49         ` Takashi Iwai
2004-06-07 13:10   ` Takashi Iwai
2004-06-04 23:37 ` Jeff Garzik
2004-06-07 13:24   ` Takashi Iwai
2004-06-07 13:47     ` Jeff Garzik
2004-06-07 13:57       ` Takashi Iwai
2004-06-07 14:05         ` Jeff Garzik
2004-06-07 14:12           ` Takashi Iwai
2004-06-07 14:18         ` Russell King
2004-06-08 13:27           ` Takashi Iwai

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20040604231456.GS12308@parcelfarce.linux.theplanet.co.uk \
    --to=viro@parcelfarce.linux.theplanet.co.uk \
    --cc=linux-kernel@vger.kernel.org \
    --cc=perex@suse.cz \
    --cc=torvalds@osdl.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox