public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Andi Kleen <ak@suse.de>
To: Manfred Spraul <manfred@colorfullife.com>
Cc: akpm@osdl.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Use numa policy API for boot time policy
Date: Sat, 5 Jun 2004 04:18:13 +0200	[thread overview]
Message-ID: <20040605041813.75e2d22d.ak@suse.de> (raw)
In-Reply-To: <40C12865.9050803@colorfullife.com>

On Sat, 05 Jun 2004 03:56:53 +0200
Manfred Spraul <manfred@colorfullife.com> wrote:

> Andi Kleen wrote:
> 
> >Suggested by Manfred Spraul.
> >
> >__get_free_pages had a hack to do node interleaving allocation at boot time.
> >This patch sets an interleave process policy using the NUMA API for init
> >and the idle threads instead. Before entering the user space init the policy
> >is reset to default again. Result is the same.
> >
> >Advantage is less code and removing of a check from a fast path.
> >
> >Removes more code than it adds.
> >
> >I verified that the memory distribution after boot is roughly the same.
> >
> >  
> >
> Does it work for order != 0 allocations? It's important that the big 
> hash tables do not end up all in node 0. AFAICS alloc_pages_current() 
> calls interleave_nodes() only for order==0 allocs.

That's correct. It will only work for order 0 allocations.

But it sounds quite bogus anyways to move the complete hash tables
to another node anyways. It would probably be better to use vmalloc() 
and a interleaving mapping for it. Then you would get the NUMA bandwidth 
benefit even for accessing single tables.

-Andi

  reply	other threads:[~2004-06-05  2:18 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-06-05  1:43 [PATCH] Use numa policy API for boot time policy Andi Kleen
2004-06-05  1:56 ` Manfred Spraul
2004-06-05  2:18   ` Andi Kleen [this message]
2004-06-05  2:32     ` Anton Blanchard
2004-06-05 10:22       ` Andi Kleen
2004-06-05 10:48         ` Andi Kleen
2004-06-09 15:44         ` Anton Blanchard
2004-06-09 15:56           ` Andi Kleen
2004-06-09 16:12             ` Anton Blanchard
2004-06-05 10:20     ` Manfred Spraul
2004-06-05 10:33       ` Andi Kleen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20040605041813.75e2d22d.ak@suse.de \
    --to=ak@suse.de \
    --cc=akpm@osdl.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=manfred@colorfullife.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox