From: William Lee Irwin III <wli@holomorphy.com>
To: Peter Williams <pwil3058@bigpond.net.au>
Cc: Con Kolivas <kernel@kolivas.org>,
Linux Kernel Mailinglist <linux-kernel@vger.kernel.org>,
Zwane Mwaikambo <zwane@linuxpower.ca>
Subject: Re: [PATCH] staircase scheduler v6.4 for 2.6.7-rc3
Date: Tue, 8 Jun 2004 16:36:10 -0700 [thread overview]
Message-ID: <20040608233610.GC1444@holomorphy.com> (raw)
In-Reply-To: <40C645F7.6070704@bigpond.net.au>
On Wed, Jun 09, 2004 at 09:04:23AM +1000, Peter Williams wrote:
> There was no need to add the extra overhead of a flag to indicate that a
> task was queued for scheduling. Testing whether run_list is empty
> achieves the same thing as reliably as the old array == NULL test did.
Overhead? Doubtful. Also, that requires the use of list_del_init()
while dequeueing, which is not in place now. Please do back the claim
with measurements. It should be easy enough to nop out set_task_queued(),
implement task_queued() via !list_empty(), and clear_task_queued() via
INIT_LIST_HEAD() for a quick performance comparison. But I'd say to
merge it even if there's no difference, as it's more self-contained.
-- wli
next prev parent reply other threads:[~2004-06-08 23:36 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-06-08 14:23 [PATCH] staircase scheduler v6.4 for 2.6.7-rc3 Con Kolivas
2004-06-08 23:04 ` Peter Williams
2004-06-08 23:36 ` William Lee Irwin III [this message]
2004-06-08 23:56 ` Peter Williams
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040608233610.GC1444@holomorphy.com \
--to=wli@holomorphy.com \
--cc=kernel@kolivas.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pwil3058@bigpond.net.au \
--cc=zwane@linuxpower.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox