Re: [PATCH 0/3] Couple of sysfs patches

Greg KH
2004-06-09T22:47:13Z

On Wed, Jun 09, 2004 at 05:32:28PM -0500, Dmitry Torokhov wrote:
> Actually, I myself want someting else -
>
> int platform_device_register_simple(struct platform_device **ppdev,
> const char *name, int id)
>
> It will allocate platform device, set name and id and release function to
> platform_device_simple_release which in turn will be hidden from outside
> world. Since the function does allocation for user is should prevent the
> abuse you were concerned about.

Ok, that sounds good. I'll take patches for that kind of interface.

But have the function return the pointer, like the class_simple
functions work. Not the ** like you just specified.

> > Unless you show me a real need for it..
> >
> > And as for the whitespace cleanup, why? The lack of spaces seem to be
> > something that the original author liked doing. There's nothing in the
> > kernel coding style guidelines that really mention it that I can see.
> >
>
> If you check the files in question there were already both styles present
> (with and without spaces). And trailing whitespace looks bloody red in my
> vi ;) Will you accept just trailing whitespace cleanup?

Hm, ok, you are correct about the duplicate styles, ok, I'll take the
whole cleanup. But things have changed in these files lately, and your
patch doesn't apply :( Care to resend this against the latest -mm
release which has all of the changes in it?

thanks,

greg k-h