From: Andreas Dilger <adilger@clusterfs.com>
To: Jesper Juhl <juhl-lkml@dif.dk>
Cc: B.Zolnierkiewicz@elka.pw.edu.pl, linux-kernel@vger.kernel.org,
linux-ide@vger.kernel.org
Subject: Re: [PATCH] tiny patch to kill warning in drivers/ide/ide.c
Date: Tue, 8 Jun 2004 20:33:08 -0600 [thread overview]
Message-ID: <20040609023308.GC24042@schnapps.adilger.int> (raw)
In-Reply-To: <Pine.LNX.4.56.0406090335260.25359@jjulnx.backbone.dif.dk>
[-- Attachment #1: Type: text/plain, Size: 903 bytes --]
On Jun 09, 2004 03:38 +0200, Jesper Juhl wrote:
> drivers/ide/ide.c: In function `ide_unregister_subdriver':
> drivers/ide/ide.c:2216: warning: implicit declaration of function `pnpide_init'
>
> I added a simple declaration of pnpide_init to drivers/ide/ide.c
>
> Here's a patch against 2.6.7-rc3 - please consider including it (or if
> that's not the way to do it, then don't) :)
Better to add the declaration into a header like linux/ide.h that is
included into both ide.c and ide-pnp.c so that when/if pnpide_init()
ever changes its prototype you will get a warning during compilation.
The only good reason to have declarations within .c files is for forward
declarations of functions only used in the same file.
Cheers, Andreas
--
Andreas Dilger
http://sourceforge.net/projects/ext2resize/
http://members.shaw.ca/adilger/ http://members.shaw.ca/golinux/
[-- Attachment #2: Type: application/pgp-signature, Size: 189 bytes --]
next prev parent reply other threads:[~2004-06-09 2:33 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-06-09 1:38 [PATCH] tiny patch to kill warning in drivers/ide/ide.c Jesper Juhl
2004-06-09 2:33 ` Andreas Dilger [this message]
2004-06-09 14:37 ` Jesper Juhl
2004-06-09 10:31 ` Bartlomiej Zolnierkiewicz
2004-06-09 14:39 ` Jesper Juhl
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040609023308.GC24042@schnapps.adilger.int \
--to=adilger@clusterfs.com \
--cc=B.Zolnierkiewicz@elka.pw.edu.pl \
--cc=juhl-lkml@dif.dk \
--cc=linux-ide@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox