From: Sam Ravnborg <sam@ravnborg.org>
To: Greg KH <greg@kroah.com>
Cc: viro@parcelfarce.linux.theplanet.co.uk,
sensors@stimpy.netroedge.com,
"Robert T. Johnson" <rtjohnso@eecs.berkeley.edu>,
Linux Kernel <linux-kernel@vger.kernel.org>
Subject: Re: Finding user/kernel pointer bugs [no html]
Date: Thu, 10 Jun 2004 22:28:03 +0200 [thread overview]
Message-ID: <20040610202803.GA3673@mars.ravnborg.org> (raw)
In-Reply-To: <20040610193207.GA1904@kroah.com>
On Thu, Jun 10, 2004 at 12:32:08PM -0700, Greg KH wrote:
> On Thu, Jun 10, 2004 at 08:14:00PM +0100, viro@parcelfarce.linux.theplanet.co.uk wrote:
> > On Thu, Jun 10, 2004 at 12:10:04PM -0700, Greg KH wrote:
> > > @@ -170,8 +170,11 @@
> > > static int DIV_TO_REG(int val)
> > > {
> > > int answer = 0;
> > > - while ((val >>= 1))
> > > + val >>= 1;
> > > + while (val) {
> > > answer++;
> > > + val >>= 1;
> > > + }
> > > return answer;
> >
> > That's less readable than the original...
>
> Hm, so we should ignore the sparse warning about the original then?
What about:
while ((val >>= 1) != 0) {
...
Readable and sparse clean (I suppose).
Sam
next prev parent reply other threads:[~2004-06-10 20:21 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-06-10 3:31 Finding user/kernel pointer bugs [no html] Robert T. Johnson
2004-06-10 4:10 ` Linus Torvalds
2004-06-10 4:48 ` Robert T. Johnson
2004-06-10 14:46 ` Linus Torvalds
2004-06-10 16:57 ` viro
2004-06-10 15:07 ` Timothy Miller
2004-06-10 15:04 ` Linus Torvalds
2004-06-10 15:26 ` Timothy Miller
2004-06-10 4:49 ` viro
2004-06-10 5:20 ` Robert T. Johnson
2004-06-10 16:58 ` Greg KH
2004-06-10 17:27 ` David Brownell
2004-06-10 17:35 ` Greg KH
2004-06-10 17:54 ` Thomas Sailer
2004-06-10 18:34 ` Greg KH
2004-06-10 18:45 ` viro
2004-06-10 18:54 ` Greg KH
2004-06-10 19:10 ` Greg KH
2004-06-10 19:14 ` viro
2004-06-10 19:32 ` Greg KH
2004-06-10 19:38 ` viro
2004-06-10 20:28 ` Sam Ravnborg [this message]
2004-06-10 20:48 ` Randy.Dunlap
2004-06-11 17:21 ` Jean Delvare
2004-06-11 17:59 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040610202803.GA3673@mars.ravnborg.org \
--to=sam@ravnborg.org \
--cc=greg@kroah.com \
--cc=linux-kernel@vger.kernel.org \
--cc=rtjohnso@eecs.berkeley.edu \
--cc=sensors@stimpy.netroedge.com \
--cc=viro@parcelfarce.linux.theplanet.co.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox