public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
* [PATCH]Re:2.6.7-rc3-mm1
@ 2004-06-10 20:45 long
  2004-06-10 19:57 ` 2.6.7-rc3-mm1 problems (ACPI and others) Grzegorz Kulewski
  2004-06-11  1:05 ` [PATCH]Re:2.6.7-rc3-mm1 William Lee Irwin III
  0 siblings, 2 replies; 5+ messages in thread
From: long @ 2004-06-10 20:45 UTC (permalink / raw)
  To: akpm, linux-kernel, wli; +Cc: tom.l.nguyen

On Wed. June 09, 2004 William Lee Irwin III wrote:
> The MSI writers have a lot to answer for. Could you test this?

Hi William,

The MSI patch has existed in the kernel since 2.6.3 and has been
validated in both UP and SMP environments. It appears another patch 
(don't know which one) redefined the value of TARGET_CPU, which is 
used by the function msi_address_init() to configure logical
target CPU. The redefinition of TARGET_CPU without checking its 
usage by other kernel code broke the build.

Your patch fixes the build but breaks the devices using MSI in 
different architectures supported by the function msi_address_init().
I have attached a patch that fixes the build and maintains cross
architecture support for MSI.

Thanks,
Long

------------------------------------------------------------------ 
diff -urN linux-2.6.7-rc3-mm1/include/asm-i386/msi.h 2.6.7-rc3-mm1-fix/include/asm-i386/msi.h
--- linux-2.6.7-rc3-mm1/include/asm-i386/msi.h	2004-05-09 22:32:52.000000000 -0400
+++ 2.6.7-rc3-mm1-fix/include/asm-i386/msi.h	2004-06-09 17:21:07.000000000 -0400
@@ -16,7 +16,7 @@
 #ifdef CONFIG_SMP
 #define MSI_TARGET_CPU		logical_smp_processor_id()
 #else
-#define MSI_TARGET_CPU		TARGET_CPUS
+#define MSI_TARGET_CPU	cpu_to_logical_apicid(first_cpu(cpu_online_map))
 #endif
 
 #endif /* ASM_MSI_H */

^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2004-06-11  1:06 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2004-06-10 20:45 [PATCH]Re:2.6.7-rc3-mm1 long
2004-06-10 19:57 ` 2.6.7-rc3-mm1 problems (ACPI and others) Grzegorz Kulewski
2004-06-10 20:47   ` Mikael Pettersson
2004-06-10 23:10   ` Pozsar Balazs
2004-06-11  1:05 ` [PATCH]Re:2.6.7-rc3-mm1 William Lee Irwin III

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox