From: Andrew Morton <akpm@osdl.org>
To: David Ford <david+challenge-response@blue-labs.org>
Cc: linux-kernel@vger.kernel.org
Subject: Re: sound driver (opti) spinlock bug, 2.6.7-rc3
Date: Sat, 12 Jun 2004 17:19:47 -0700 [thread overview]
Message-ID: <20040612171947.31218266.akpm@osdl.org> (raw)
In-Reply-To: <40CB632B.2070706@blue-labs.org>
David Ford <david+challenge-response@blue-labs.org> wrote:
>
> sound/isa/opti9xx/opti92x-ad1848.c:428:
> spin_lock(sound/isa/opti9xx/opti92x-ad1848.c:cf40eea0) already locked by
> sound/isa/opti9xx/opti92x-ad1848.c/604
Like this?
The locking in there seems fairly optimistic - looks like someone did a
cli() translation on it.
--- 25/sound/isa/opti9xx/opti92x-ad1848.c~opti92x-ad1848-locking-fix 2004-06-12 17:09:38.699325296 -0700
+++ 25-akpm/sound/isa/opti9xx/opti92x-ad1848.c 2004-06-12 17:16:38.029577408 -0700
@@ -601,13 +601,11 @@ __skip_base:
dma_bits |= 0x04;
#endif /* CS4231 || OPTi93X */
- spin_lock_irqsave(&chip->lock, flags);
#ifndef OPTi93X
- outb(irq_bits << 3 | dma_bits, chip->wss_base);
+ outb(irq_bits << 3 | dma_bits, chip->wss_base);
#else /* OPTi93X */
snd_opti9xx_write(chip, OPTi9XX_MC_REG(3), (irq_bits << 3 | dma_bits));
#endif /* OPTi93X */
- spin_unlock_irqrestore(&chip->lock, flags);
__skip_resources:
if (chip->hardware > OPTi9XX_HW_82C928) {
_
next prev parent reply other threads:[~2004-06-13 0:20 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-06-12 20:10 sound driver (opti) spinlock bug, 2.6.7-rc3 David Ford
2004-06-13 0:19 ` Andrew Morton [this message]
2004-06-14 17:20 ` Takashi Iwai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040612171947.31218266.akpm@osdl.org \
--to=akpm@osdl.org \
--cc=david+challenge-response@blue-labs.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox