From: Kevin Corry <kevcorry@us.ibm.com>
To: Andrew Morton <akpm@osdl.org>
Cc: LKML <linux-kernel@vger.kernel.org>
Subject: [PATCH] DM 4/5: dm-raid1.c: Make delayed_bios a bio_list
Date: Mon, 14 Jun 2004 13:18:33 +0000 [thread overview]
Message-ID: <200406141318.33193.kevcorry@us.ibm.com> (raw)
In-Reply-To: <200406141309.31127.kevcorry@us.ibm.com>
dm-raid1.c: Make struct region::delayed_bios a bio_list instead of a bio*.
This will ensure the queued bios are kept in the proper order.
Signed-off-by: Kevin Corry <kevcorry@us.ibm.com>
--- diff/drivers/md/dm-raid1.c 2004-06-14 09:29:56.946129416 +0000
+++ source/drivers/md/dm-raid1.c 2004-06-14 09:30:12.916701520 +0000
@@ -103,7 +103,7 @@
struct list_head list;
atomic_t pending;
- struct bio *delayed_bios;
+ struct bio_list delayed_bios;
};
/*
@@ -244,7 +244,7 @@
INIT_LIST_HEAD(&nreg->list);
atomic_set(&nreg->pending, 0);
- nreg->delayed_bios = NULL;
+ bio_list_init(&nreg->delayed_bios);
write_lock_irq(&rh->hash_lock);
reg = __rh_lookup(rh, region);
@@ -310,14 +310,12 @@
return state == RH_CLEAN || state == RH_DIRTY;
}
-static void dispatch_bios(struct mirror_set *ms, struct bio *bio)
+static void dispatch_bios(struct mirror_set *ms, struct bio_list *bio_list)
{
- struct bio *nbio;
+ struct bio *bio;
- while (bio) {
- nbio = bio->bi_next;
+ while ((bio = bio_list_pop(bio_list))) {
queue_bio(ms, bio, WRITE);
- bio = nbio;
}
}
@@ -361,7 +359,7 @@
list_for_each_entry_safe (reg, next, &recovered, list) {
rh->log->type->clear_region(rh->log, reg->key);
rh->log->type->complete_resync_work(rh->log, reg->key, 1);
- dispatch_bios(rh->ms, reg->delayed_bios);
+ dispatch_bios(rh->ms, ®->delayed_bios);
up(&rh->recovery_count);
mempool_free(reg, rh->region_pool);
}
@@ -516,8 +514,7 @@
read_lock(&rh->hash_lock);
reg = __rh_find(rh, bio_to_region(rh, bio));
- bio->bi_next = reg->delayed_bios;
- reg->delayed_bios = bio;
+ bio_list_add(®->delayed_bios, bio);
read_unlock(&rh->hash_lock);
}
next prev parent reply other threads:[~2004-06-14 18:18 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-06-14 13:09 [PATCH] DM 0/5: Device-mapper cleanups Kevin Corry
2004-06-14 13:16 ` [PATCH] DM 1/5: Create/destroy kcopyd on demand Kevin Corry
2004-06-14 13:17 ` [PATCH] DM 2/5: Use structure assignments instead of memcpy Kevin Corry
2004-06-14 13:18 ` [PATCH] DM 3/5: dm-io: Error handling Kevin Corry
2004-06-14 13:18 ` Kevin Corry [this message]
2004-06-14 13:19 ` [PATCH] DM 5/5: dm-raid1.c: Use list_for_each_entry_safe Kevin Corry
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200406141318.33193.kevcorry@us.ibm.com \
--to=kevcorry@us.ibm.com \
--cc=akpm@osdl.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox