public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Andi Kleen <ak@muc.de>
To: Manfred Spraul <manfred@colorfullife.com>
Cc: pj@sgi.com, linux-kernel@vger.kernel.org,
	lse-tech <lse-tech@lists.sourceforge.net>, Andi Kleen <ak@muc.de>,
	Anton Blanchard <anton@samba.org>
Subject: Re: NUMA API observations
Date: 15 Jun 2004 13:03:20 +0200
Date: Tue, 15 Jun 2004 13:03:20 +0200	[thread overview]
Message-ID: <20040615110320.GD50463@colin2.muc.de> (raw)
In-Reply-To: <40CE824D.9020300@colorfullife.com>

On Tue, Jun 15, 2004 at 06:59:57AM +0200, Manfred Spraul wrote:
> >
> >
> >>I will probably make it loop and double the buffer until EINVAL
> >>ends or it passes a page and add a nasty comment.
> >
> >I agree that a loop is needed.  And yes someone didn't do a very
> >good job of designing this interface.
> >
> > 
> >
> What about fixing the interface instead? For example if user_mask_ptr 
> NULL, then sys_sched_{get,set}affinity return the bitmap size.

Or maybe just a sysctl. But it doesn't really help because
applications have to work with older kernels. I think
cpumask_t is more an kernel internal implementation detail
and should not really be exposed to user space, so 
it's better not to do the sysctl neither.

However the clear bugs in the kernel API that should be fixed:
- It should EINVAL for bits set above cpumask_t 
- It should not EINVAL as long as the passed in mask
covers all online CPUs.

-Andi

  parent reply	other threads:[~2004-06-15 11:03 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-06-15  4:59 NUMA API observations Manfred Spraul
2004-06-15  6:18 ` Paul Jackson
2004-06-15 11:03 ` Andi Kleen [this message]
2004-06-15 17:37   ` Manfred Spraul
2004-06-15 18:32     ` Paul Jackson
2004-06-15 18:18   ` Paul Jackson
     [not found] <271SM-3DT-7@gated-at.bofh.it>
     [not found] ` <27lI4-29E-19@gated-at.bofh.it>
2004-06-15 13:27   ` Andi Kleen
     [not found] ` <272lY-44B-49@gated-at.bofh.it>
     [not found]   ` <2772a-7VK-9@gated-at.bofh.it>
     [not found]     ` <279nf-1id-3@gated-at.bofh.it>
2004-06-15 13:52       ` Bill Davidsen
  -- strict thread matches above, loose matches on Subject: below --
2004-06-14 15:36 Anton Blanchard
2004-06-14 16:17 ` Andi Kleen
2004-06-14 21:21   ` Paul Jackson
2004-06-14 23:44     ` Andi Kleen
2004-06-15  0:06       ` Paul Jackson
2004-06-15  0:20         ` Andi Kleen
2004-06-15  0:25           ` Paul Jackson
2004-06-14 21:40   ` Anton Blanchard
2004-06-14 23:49     ` Andi Kleen
2004-06-15 13:50       ` Jesse Barnes
2004-06-15 12:53 ` Thomas Zehetbauer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20040615110320.GD50463@colin2.muc.de \
    --to=ak@muc.de \
    --cc=anton@samba.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lse-tech@lists.sourceforge.net \
    --cc=manfred@colorfullife.com \
    --cc=pj@sgi.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox