From: Ingo Molnar <mingo@elte.hu>
To: Linus Torvalds <torvalds@osdl.org>
Cc: Nick Piggin <nickpiggin@yahoo.com.au>,
Herbert Xu <herbert@gondor.apana.org.au>,
"Martin J. Bligh" <mbligh@aracnet.com>,
kernel@kolivas.org, linux-kernel@vger.kernel.org,
piggin@cyberone.com.au, akpm@osdl.org, wli@holomorphy.com,
markw@osdl.org
Subject: Re: [PATCH] Performance regression in 2.6.7-rc3
Date: Wed, 16 Jun 2004 09:02:40 +0200 [thread overview]
Message-ID: <20040616070240.GA25910@elte.hu> (raw)
In-Reply-To: <Pine.LNX.4.58.0406152009220.4142@ppc970.osdl.org>
* Linus Torvalds <torvalds@osdl.org> wrote:
> I agree. However, I still think we should do my suggested
> "wake_up_new(p,clone_flags)" thing, and then have the logic on whether
> to try to care about threading or not be in schedule.c, not in
> kernel/fork.c.
>
> The fact is, fork.c shouldn't try to make scheduling decisions. But it
> could inform the scheduler about the new process, and THAT can then
> make the decisions.
agreed, and i did it in a similar way initially (by adding the clone
flags to wake_up_process()) but went for the smaller patch. The only
reason i pushed it into fork.c initially was to avoid having to change
dozens of other files (most of them in various architectures) that use
wake_up_process(). It wasnt (and still isnt) clear at all whether we
want to do any fork/clone-time balancing.
Ingo
next prev parent reply other threads:[~2004-06-16 7:32 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-06-12 0:28 [PATCH] Performance regression in 2.6.7-rc3 Con Kolivas
2004-06-12 7:58 ` Nick Piggin
2004-06-15 4:56 ` Ingo Molnar
2004-06-15 13:11 ` Con Kolivas
2004-06-15 15:02 ` Martin J. Bligh
2004-06-16 2:14 ` Herbert Xu
2004-06-16 3:05 ` Nick Piggin
2004-06-16 3:10 ` Linus Torvalds
2004-06-16 3:18 ` Nick Piggin
2004-06-16 7:02 ` Ingo Molnar [this message]
2004-06-16 3:09 ` Linus Torvalds
2004-06-16 14:54 ` Martin J. Bligh
2004-06-16 3:00 ` Nick Piggin
2004-06-16 1:22 ` Con Kolivas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040616070240.GA25910@elte.hu \
--to=mingo@elte.hu \
--cc=akpm@osdl.org \
--cc=herbert@gondor.apana.org.au \
--cc=kernel@kolivas.org \
--cc=linux-kernel@vger.kernel.org \
--cc=markw@osdl.org \
--cc=mbligh@aracnet.com \
--cc=nickpiggin@yahoo.com.au \
--cc=piggin@cyberone.com.au \
--cc=torvalds@osdl.org \
--cc=wli@holomorphy.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox