Re: JFS compilation fix [was Re: Linux 2.6.7]

Tomas Szepe
2004-06-16T13:08:53Z

On Jun-16 2004, Wed, 07:55 -0500
Dave Kleikamp <shaggy@austin.ibm.com> wrote:

> On Wed, 2004-06-16 at 03:07, Tomas Szepe wrote:
> > Here's a trivial patch to fix JFS compilation in 2.6.7. The error
> > only happens in specific configs -- one such config can be found here:
> > http://www.pinerecords.com/kala/_nonpub/.config.louise26
>
> I don't know why gcc-3.2.2 doesn't complain about this one, as I have
> compiled this numerous times.
>
> Your patch has an unnecessary include of jfs_dtree.h. jfs_dtree.h is
> included by jfs_inline.h, and is not needed in jfs_dtree.c.

Oh, right.

> > I don't have the time to narrow the problem down to the config
> > entry that gets jfs_dtree.c to include jfs_dtree.h (jfs_dtree.c
> > itself doesn't have any relevat ifdefs).
>
> My guess is the config entry is CONFIG_JFS_FS. :^)

Well, it just so happens that I have two .config files, both listing
CONFIG_JFS_FS=m, and without the patch, exactly one of them fails
compilation (on the same cluster, distcc gcc 3.4.0). That is why
I assumed the include was missing -- the moving of the declaration
in my patch was only meant as an extra clean up for bonus points.
;)

--
Tomas Szepe <szepe@pinerecords.com>