public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Greg KH <greg@kroah.com>
To: Andrew Morton <akpm@osdl.org>
Cc: linux-kernel@vger.kernel.org
Subject: [PATCH] remove EXPORT_SYMBOL(kallsyms_lookup)
Date: Thu, 17 Jun 2004 09:29:28 -0700	[thread overview]
Message-ID: <20040617162927.GA12498@kroah.com> (raw)

Hi,

Distros have started to ship kernels with this patch, as it seems that
some unnamed binary module authors are already abusing this function (as
well as some open source modules, like the openib code.)  I could not
find any valid reason why this symbol should be exported, so here's a
patch against 2.6.7 that removes it.

Signed-off-by: Greg Kroah-Hartman <greg@kroah.com>

thanks,

greg k-h


diff -Nru a/kernel/kallsyms.c b/kernel/kallsyms.c
--- a/kernel/kallsyms.c	Thu Jun 17 09:26:17 2004
+++ b/kernel/kallsyms.c	Thu Jun 17 09:26:17 2004
@@ -320,5 +320,4 @@
 }
 __initcall(kallsyms_init);
 
-EXPORT_SYMBOL(kallsyms_lookup);
 EXPORT_SYMBOL(__print_symbol);

             reply	other threads:[~2004-06-17 16:30 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-06-17 16:29 Greg KH [this message]
2004-06-17 17:31 ` [PATCH] remove EXPORT_SYMBOL(kallsyms_lookup) Oleg Drokin
2004-06-17 17:50   ` Greg KH
2004-06-17 19:28   ` Christoph Hellwig
2004-06-17 20:14   ` Dave Kleikamp

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20040617162927.GA12498@kroah.com \
    --to=greg@kroah.com \
    --cc=akpm@osdl.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox