Re: [PATCH 0/3] Couple of sysfs patches

Greg KH
2004-06-09T22:14:54Z

On Wed, Jun 09, 2004 at 02:21:24AM -0500, Dmitry Torokhov wrote:
> Hi,
>
> I am trying to add sysfs support to the serio subsystem and I would like you
> to consider the following changes:
>
> - when registering platform device, if device id is set to -1, do not add it
> as a suffix to device's name. It can be used when there is only one device.
> The reason for change - i find that i80420 looks ugly, just i8042 is much
> better ;)

That sounds sane.

> - create platform_device_simple_releasse function that would just free memory
> occupied by platform device. Having such release routine in core allows
> drivers implementing simple platform devices not wait in module unload code
> till last reference to the device is dropped.

I'm _very_ leary of applying this. It could be abused very badly
(by putting the platform_device as the first object in the structure and
relying on this function to kfree the whole thing.) So sorry, but no.

Unless you show me a real need for it..

And as for the whitespace cleanup, why? The lack of spaces seem to be
something that the original author liked doing. There's nothing in the
kernel coding style guidelines that really mention it that I can see.

So, care to just send me the name change patch against the latest tree?

thanks,

greg k-h