Re: [PATCH 0/3] Couple of sysfs patches

Dmitry Torokhov
2004-06-18T20:03:10Z

Russell King wrote:
> void platform_device_unregister(struct platform_device * pdev)
> {
> - if (pdev)
> + int i;
> +
> + if (pdev) {
> device_unregister(&pdev->dev);
> +
> + for (i = 0; i < pdev->num_resources; i++) {
> + struct resource *r = &pdev->resource[i];
> + if (r->flags & (IORESOURCE_MEM|IORESOURCE_IO))
> + release_resource(r);
> + }
> + }
> }

Ok, now it's possibly just a nitpicking but would not it be "more correct"
if allocated resources were freed in reverse order?

--
Dmitry