Re: [PATCH] Stop printk printing non-printable chars

Albert Cahalan
2004-06-19T22:34:19Z

David Woodhouse writes:

> Please don't do that -- it makes printing UTF-8 impossible.
> While I'd not argue that now is the time to start outputting
> UTF-8 all over the place, I wouldn't accept that it's a good
> time to _prevent_ it either, as your patch would do.
>
> If you want to post-process printk output, don't do it in the kernel.

It is dangerous to let the 0x9b character go out
to a serial console. It means the same as ESC [ does
when you have a normal 8-bit terminal.

Non-cannonical UTF-8 encoding for ESC and other
troublesome characters may also cause problems.