Re: [PATCH] Stop printk printing non-printable chars

Arjan van de Ven
2004-06-19T16:10:00Z

[-- Attachment #1: Type: text/plain, Size: 1261 bytes --]

On Sat, 2004-06-19 at 17:49, matthew-lkml@newtoncomputing.co.uk wrote:
> On Sat, Jun 19, 2004 at 12:18:24PM +0100, David Woodhouse wrote:
> > On Fri, 2004-06-18 at 21:53 +0100, matthew-lkml@newtoncomputing.co.uk
> > wrote:
> > > The main problem seems to be in ACPI, but I don't see any reason for
> > > printk to even consider printing _any_ non-printable characters at all.
> > > It makes all characters out of the range 32..126 (except for newline)
> > > print as a '?'.
> >
> > Please don't do that -- it makes printing UTF-8 impossible. While I'd
> > not argue that now is the time to start outputting UTF-8 all over the
> > place, I wouldn't accept that it's a good time to _prevent_ it either,
> > as your patch would do.
>
> Please forgive me if I'm wrong on this, but I seem to remember reading
> something a while ago indicating that the kernel is and always will be
> internally English (i.e. debugging messages and the like) as there is no
> need to bloat it with many different languages (that can be done in
> userspace). As printk is really just a log system, I personally don't
> see any way that it should ever print anything other than ASCII.

english != no-UTF8.

Names of people and things still can be UTF8 ....

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 189 bytes --]