From: matthew-lkml@newtoncomputing.co.uk
To: David Woodhouse <dwmw2@infradead.org>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Stop printk printing non-printable chars
Date: Sat, 19 Jun 2004 16:49:07 +0100 [thread overview]
Message-ID: <20040619154907.GE5286@newtoncomputing.co.uk> (raw)
In-Reply-To: <1087643904.5494.7.camel@imladris.demon.co.uk>
On Sat, Jun 19, 2004 at 12:18:24PM +0100, David Woodhouse wrote:
> On Fri, 2004-06-18 at 21:53 +0100, matthew-lkml@newtoncomputing.co.uk
> wrote:
> > The main problem seems to be in ACPI, but I don't see any reason for
> > printk to even consider printing _any_ non-printable characters at all.
> > It makes all characters out of the range 32..126 (except for newline)
> > print as a '?'.
>
> Please don't do that -- it makes printing UTF-8 impossible. While I'd
> not argue that now is the time to start outputting UTF-8 all over the
> place, I wouldn't accept that it's a good time to _prevent_ it either,
> as your patch would do.
Please forgive me if I'm wrong on this, but I seem to remember reading
something a while ago indicating that the kernel is and always will be
internally English (i.e. debugging messages and the like) as there is no
need to bloat it with many different languages (that can be done in
userspace). As printk is really just a log system, I personally don't
see any way that it should ever print anything other than ASCII.
(Yes, of course some parts of the kernel, like filesystems, do need to
be able to handle UTF-8 etc, but not all.)
--
Matthew
next prev parent reply other threads:[~2004-06-19 15:49 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-06-18 20:53 [PATCH] Stop printk printing non-printable chars matthew-lkml
2004-06-18 21:08 ` Linus Torvalds
2004-06-18 22:44 ` Jesper Juhl
2004-06-18 23:52 ` matthew-lkml
2004-06-19 4:18 ` Willy Tarreau
2004-06-19 10:27 ` Matthias Urlichs
2004-06-19 23:00 ` Dave Jones
2004-06-19 1:23 ` Matthias Urlichs
2004-06-19 1:43 ` Jesper Juhl
2004-06-19 10:20 ` Matthias Urlichs
2004-06-18 21:32 ` Jan-Benedict Glaw
2004-06-18 21:58 ` Pekka Pietikainen
2004-06-19 0:03 ` matthew-lkml
2004-06-19 8:31 ` Jan-Benedict Glaw
2004-06-19 11:18 ` David Woodhouse
2004-06-19 15:49 ` matthew-lkml [this message]
2004-06-19 16:09 ` Arjan van de Ven
2004-06-20 2:19 ` Horst von Brand
2004-06-20 14:17 ` David Woodhouse
2004-06-20 20:06 ` Jeff Woods
-- strict thread matches above, loose matches on Subject: below --
2004-06-19 20:12 Albert Cahalan
2004-06-19 22:56 ` Jan-Benedict Glaw
2004-06-20 4:02 Albert Cahalan
2004-06-20 8:38 ` David Woodhouse
2004-06-20 8:49 ` Jan-Benedict Glaw
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040619154907.GE5286@newtoncomputing.co.uk \
--to=matthew-lkml@newtoncomputing.co.uk \
--cc=dwmw2@infradead.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox