Re: [PATCH 2.6.7] ext3 fill_super reporting

[Andrew Morton <akpm@osdl.org>]

FabF <fabian.frederick@skynet.be> wrote:
>
> Andrew,
> 
> This patch does the following :

> 	-Explicit max_per_group authorized for block, fragments, inodes 

Sorry, but this is just too trivial to be worth the processing.  The
compiler is perfectly capable of retaining the `blocksize * 8' result for
later use and this part of your patch actually increases the code size
slightly.

> 	-Remove groupmax recalculations

I don't know what this means.

> 	-When mounting ext2 or ^has_journal , we know filesystem is extX
> relevant.
> 
> 
> 	btw, I see a FIXME in journal_update for new journal creation.

There is no such thing as journal_update.  I assume you're referring to the
handling of the "journal=update" mount option.  Please be more careful when
identifying these things.

> Does it
> mean we should patch to have e.g. journalupdate=<filename> or that note
> is obsolete ?

No, I see no need to be able to convert an ext2 filesystem to ext3 within
the kernel.  Nobody will bother to work on this.