From: Andrew Morton <akpm@osdl.org>
To: Jeff Garzik <jgarzik@pobox.com>
Cc: torvalds@osdl.org, linux-kernel@vger.kernel.org
Subject: Re: 2.6.7-bk way too fast
Date: Mon, 21 Jun 2004 01:48:37 -0700 [thread overview]
Message-ID: <20040621014837.6b52fa2e.akpm@osdl.org> (raw)
In-Reply-To: <40D64DF7.5040601@pobox.com>
Jeff Garzik <jgarzik@pobox.com> wrote:
>
> Something is definitely screwy with the latest -bk.
Would you believe that there is a totally separate bug in the latest -mm
which has exactly the same symptoms?
mark_offset_tsc() does
if (lost && abs(delay - delay_at_last_interrupt) > (900000/HZ))
jiffies_64++;
which is doing abs(unsigned long).
Which works OK if abs() in a function, but I made it a macro.
This fixes it up.
diff -puN include/linux/kernel.h~abs-fix-fix include/linux/kernel.h
--- 25/include/linux/kernel.h~abs-fix-fix 2004-06-21 01:42:24.283873616 -0700
+++ 25-akpm/include/linux/kernel.h 2004-06-21 01:43:08.150204920 -0700
@@ -55,7 +55,12 @@ void __might_sleep(char *file, int line)
#endif
#define abs(x) ({ \
- typeof(x) __x = (x); \
+ int __x = (x); \
+ (__x < 0) ? -__x : __x; \
+ })
+
+#define labs(x) ({ \
+ long __x = (x); \
(__x < 0) ? -__x : __x; \
})
_
next prev parent reply other threads:[~2004-06-21 8:49 UTC|newest]
Thread overview: 39+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-06-21 2:54 2.6.7-bk way too fast Jeff Garzik
2004-06-21 3:29 ` Ricky Beam
2004-06-21 7:20 ` Felipe Alfaro Solana
2004-06-21 8:23 ` Vojtech Pavlik
2004-07-02 7:53 ` David Woodhouse
2004-07-02 12:56 ` Vojtech Pavlik
2004-06-21 3:36 ` Jeff Garzik
2004-06-21 3:49 ` Matt H.
2004-06-21 11:53 ` Marcel Holtmann
2004-06-21 3:52 ` Zwane Mwaikambo
2004-06-21 3:55 ` Zwane Mwaikambo
2004-06-21 4:02 ` Andrew Morton
2004-06-21 5:00 ` Norberto Bensa
2004-06-21 5:39 ` Norberto Bensa
2004-06-21 6:16 ` Linus Torvalds
2004-06-21 7:05 ` Clemens Schwaighofer
2004-06-21 7:18 ` Matt H.
2004-06-21 7:16 ` Andrew Morton
2004-06-21 8:15 ` Matt H.
2004-06-21 8:20 ` Clemens Schwaighofer
2004-06-21 9:25 ` Clemens Schwaighofer
2004-06-21 10:24 ` Felipe Alfaro Solana
2004-06-21 7:37 ` Linus Torvalds
2004-06-21 9:52 ` Jeff Sipek
2004-06-21 16:41 ` Jeff Sipek
2004-06-21 7:19 ` Jeff Sipek
2004-06-21 5:11 ` Jeff Garzik
2004-06-21 5:08 ` Aubin LaBrosse
2004-06-21 8:22 ` Vojtech Pavlik
2004-06-21 10:26 ` Felipe Alfaro Solana
2004-06-21 11:02 ` Vojtech Pavlik
2004-06-21 8:48 ` Andrew Morton [this message]
2004-06-21 9:17 ` Matt H.
2004-06-21 9:56 ` Jeff Sipek
2004-06-21 10:47 ` Felipe Alfaro Solana
2004-06-21 16:55 ` Norberto Bensa
-- strict thread matches above, loose matches on Subject: below --
2004-06-21 13:20 Sau Dan Lee
2004-06-21 15:17 ` Vojtech Pavlik
2004-06-21 15:25 ` Sau Dan Lee
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040621014837.6b52fa2e.akpm@osdl.org \
--to=akpm@osdl.org \
--cc=jgarzik@pobox.com \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox