From: Andrew Morton <akpm@osdl.org>
To: Paul Fulghum <paulkf@microgate.com>
Cc: da-x@colinux.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] missing NULL check in drivers/char/n_tty.c
Date: Mon, 21 Jun 2004 11:46:05 -0700 [thread overview]
Message-ID: <20040621114605.4df2c05e.akpm@osdl.org> (raw)
In-Reply-To: <40D6F986.3010904@microgate.com>
Paul Fulghum <paulkf@microgate.com> wrote:
>
> 13 other drivers call ldisc.chars_in_buffer without checking
> for ldisc.chars_in_buffer == NULL, but only inside conditional
> compilation for debug output. The value is not used, only logged.
> These conditional debug items look like cut and paste from
> one serial driver to another, and I doubt
> they have been recently used (or used at all).
>
> Which would be better?
> 1. Ignore this
> 2. Fix conditional debug output to check
> for ldisc.chars_in_buffer==NULL
> 3. Remove conditional debug output
Option 1 is quite valid. There are no bugs here, yes?
If someone for some reason wants to clean all this up, the best way would
be to require that ->chars_in_buffer always be valid, hence remove all
those checks.
next prev parent reply other threads:[~2004-06-21 18:47 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-06-21 6:38 [PATCH] missing NULL check in drivers/char/n_tty.c Dan Aloni
2004-06-21 6:58 ` Andrew Morton
2004-06-21 7:36 ` Dan Aloni
2004-06-21 7:39 ` Andrew Morton
2004-06-21 8:24 ` Dan Aloni
2004-06-21 15:06 ` Paul Fulghum
2004-06-21 18:46 ` Andrew Morton [this message]
2004-06-21 19:52 ` Paul Fulghum
2004-06-21 22:48 ` Dan Aloni
2004-06-21 23:56 ` Paul Fulghum
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040621114605.4df2c05e.akpm@osdl.org \
--to=akpm@osdl.org \
--cc=da-x@colinux.org \
--cc=linux-kernel@vger.kernel.org \
--cc=paulkf@microgate.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox