From: Paul Jackson <pj@sgi.com>
To: Russell King <rmk+lkml@arm.linux.org.uk>
Cc: torvalds@osdl.org, linux-kernel@vger.kernel.org, akpm@osdl.org,
rusty@rustcorp.com.au
Subject: Re: 2.6.7-bk: asm/setup.h and linux/init.h
Date: Sat, 26 Jun 2004 16:24:29 -0700 [thread overview]
Message-ID: <20040626162429.4592cced.pj@sgi.com> (raw)
In-Reply-To: <20040626174904.B30532@flint.arm.linux.org.uk>
Could someone speak a few words on why a patch such as this is
desirable?
Apparently, there is more value to avoiding non-essential include's than
I realize. I'd have preferred doing a memcpy of "sizeof(some_struct)"
over doing it for SOME_STRUCT_SIZE constant, and I'd have thought it
appropriate to include whatever header files were needed to do that.
The simple "wc -l" size of the kernel source goes up a couple of lines,
the code complexity is unchanged, and the generated code is unchanged.
So obviously none of those factors motivate this change.
--
I won't rest till it's the best ...
Programmer, Linux Scalability
Paul Jackson <pj@sgi.com> 1.650.933.1373
next prev parent reply other threads:[~2004-06-26 23:24 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-06-26 14:35 2.6.7-bk: asm/setup.h and linux/init.h Russell King
2004-06-26 16:05 ` Linus Torvalds
2004-06-26 16:49 ` Russell King
2004-06-26 23:24 ` Paul Jackson [this message]
2004-06-26 23:34 ` Rusty Russell
2004-06-26 23:56 ` Paul Jackson
2004-06-26 23:30 ` Rusty Russell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040626162429.4592cced.pj@sgi.com \
--to=pj@sgi.com \
--cc=akpm@osdl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rmk+lkml@arm.linux.org.uk \
--cc=rusty@rustcorp.com.au \
--cc=torvalds@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox