From: David Gibson <david@gibson.dropbear.id.au>
To: Oleg Nesterov <oleg@tv-sign.ru>
Cc: linux-kernel@vger.kernel.org, Andrew Morton <akpm@osdl.org>,
"Chen, Kenneth W" <kenneth.w.chen@intel.com>
Subject: Re: [PATCH] kill mm_struct.used_hugetlb
Date: Mon, 28 Jun 2004 11:05:24 +1000 [thread overview]
Message-ID: <20040628010524.GA5006@zax> (raw)
In-Reply-To: <40DD7814.779DEF17@tv-sign.ru>
On Sat, Jun 26, 2004 at 05:20:20PM +0400, Oleg Nesterov wrote:
> Hello.
>
> mm_struct.used_hugetlb used to eliminate costly find_vma()
> from follow_page(). Now it is used only in ia64 version of
> follow_huge_addr(). I know nothing about ia64, but this
> REGION_NUMBER() looks simple enough to kill used_hugetlb.
>
> There is debug version (commented out) of follow_huge_addr()
> in i386 which looks at used_hugetlb, but it can work without
> this check.
>
> Am i missed somethimg?
Sounds like an excellent idea to me. The find_vma()s were already
bogus - no-one used the vma returned by hugepage_vma(), except to
check if it was NULL or not. On all archs, whether the address is
hugepage or not can be determined from the address, either by walking
the pagetables or just by checking the address's range.
--
David Gibson | For every complex problem there is a
david AT gibson.dropbear.id.au | solution which is simple, neat and
| wrong.
http://www.ozlabs.org/people/dgibson
prev parent reply other threads:[~2004-06-28 1:44 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-06-26 13:20 [PATCH] kill mm_struct.used_hugetlb Oleg Nesterov
2004-06-28 1:05 ` David Gibson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040628010524.GA5006@zax \
--to=david@gibson.dropbear.id.au \
--cc=akpm@osdl.org \
--cc=kenneth.w.chen@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=oleg@tv-sign.ru \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox