From: Russell King <rmk+lkml@arm.linux.org.uk>
To: Coywolf Qi Hunt <coywolf@greatcn.org>
Cc: linux-kernel@vger.kernel.org, akpm@osdl.org
Subject: Re: [BUG FIX] [PATCH] fork_init() max_low_pfn fixes potential OOM bug on big highmem machine
Date: Mon, 28 Jun 2004 17:53:25 +0100 [thread overview]
Message-ID: <20040628175325.B9214@flint.arm.linux.org.uk> (raw)
In-Reply-To: <40E03F71.8010902@greatcn.org>; from coywolf@greatcn.org on Mon, Jun 28, 2004 at 11:55:29PM +0800
On Mon, Jun 28, 2004 at 11:55:29PM +0800, Coywolf Qi Hunt wrote:
> <http://localhost/lxr/ident?i=start_kernel>Hello all,
>
> On machine with 16G(or 8G if 4k stacks) or more memory, high max_threads
> could let system run out of low memory.
> This patch decides max_threads by the amount of low memory instead of
> the total physical memory.
> Systems without high memory would not be affected.
This is wrong - max_low_pfn can be high on systems where physical RAM
doesn't start at address 0. Such is very common on ARM platforms,
where RAM is located at 0xa0000000 or 0xc0000000 physical, which
leads to any calculation based upon max_low_pfn to believe we have
more than 3GB of RAM when we may only have 64MB or so.
I think we may need a num_lowpages for this...
--
Russell King
Linux kernel 2.6 ARM Linux - http://www.arm.linux.org.uk/
maintainer of: 2.6 PCMCIA - http://pcmcia.arm.linux.org.uk/
2.6 Serial core
next prev parent reply other threads:[~2004-06-28 16:53 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-06-28 15:55 [BUG FIX] [PATCH] fork_init() max_low_pfn fixes potential OOM bug on big highmem machine Coywolf Qi Hunt
2004-06-28 16:53 ` Russell King [this message]
2004-06-29 10:48 ` Coywolf Qi Hunt
2004-06-29 10:58 ` Russell King
2004-06-30 9:56 ` [BUG FIX] [ARM/ARM26] find_memend_and_nodes bug fix Coywolf Qi Hunt
2004-06-29 11:11 ` [BUG FIX] [PATCH] fork_init() max_low_pfn fixes potential OOM bug on big highmem machine Chris Wedgwood
2004-06-30 10:43 ` [BUG FIX] fork_init() " Coywolf Qi Hunt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040628175325.B9214@flint.arm.linux.org.uk \
--to=rmk+lkml@arm.linux.org.uk \
--cc=akpm@osdl.org \
--cc=coywolf@greatcn.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox