From: Olaf Hering <olh@suse.de>
To: Andrew Morton <akpm@osdl.org>,
linux-kernel@vger.kernel.org, jsimmons@infradead.org
Subject: [PATCH] signed bug in drivers/video/console/fbcon.c con2fb_map[]
Date: Mon, 28 Jun 2004 21:30:18 +0200 [thread overview]
Message-ID: <20040628193018.GA648@suse.de> (raw)
drivers/video/console/fbcon.c:310: warning: comparison is always true due to limited range of data type
char can be either signed or unsigned, depending on the target system.
patch is against 2.6.7-bk11
--- drivers/video/console/fbcon.c
+++ drivers/video/console/fbcon.c 2004/06/28 19:22:45
@@ -101,7 +101,7 @@
#endif
struct display fb_display[MAX_NR_CONSOLES];
-char con2fb_map[MAX_NR_CONSOLES];
+signed char con2fb_map[MAX_NR_CONSOLES];
static int logo_height;
static int logo_lines;
static int logo_shown = -1;
--- drivers/video/console/fbcon.h
+++ drivers/video/console/fbcon.h 2004/06/28 19:23:06
@@ -36,7 +36,7 @@
};
/* drivers/video/console/fbcon.c */
-extern char con2fb_map[MAX_NR_CONSOLES];
+extern signed char con2fb_map[MAX_NR_CONSOLES];
extern int set_con2fb_map(int unit, int newidx);
/*
--
USB is for mice, FireWire is for men!
sUse lINUX ag, nÜRNBERG
reply other threads:[~2004-06-28 19:32 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040628193018.GA648@suse.de \
--to=olh@suse.de \
--cc=akpm@osdl.org \
--cc=jsimmons@infradead.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox