public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
* [PATCH] signed bug in drivers/video/console/fbcon.c con2fb_map[]
@ 2004-06-28 19:30 Olaf Hering
  0 siblings, 0 replies; only message in thread
From: Olaf Hering @ 2004-06-28 19:30 UTC (permalink / raw)
  To: Andrew Morton, linux-kernel, jsimmons


drivers/video/console/fbcon.c:310: warning: comparison is always true due to limited range of data type

char can be either signed or unsigned, depending on the target system.
patch is against 2.6.7-bk11


--- drivers/video/console/fbcon.c
+++ drivers/video/console/fbcon.c	2004/06/28 19:22:45
@@ -101,7 +101,7 @@
 #endif
 
 struct display fb_display[MAX_NR_CONSOLES];
-char con2fb_map[MAX_NR_CONSOLES];
+signed char con2fb_map[MAX_NR_CONSOLES];
 static int logo_height;
 static int logo_lines;
 static int logo_shown = -1;
--- drivers/video/console/fbcon.h
+++ drivers/video/console/fbcon.h	2004/06/28 19:23:06
@@ -36,7 +36,7 @@
 };
 
 /* drivers/video/console/fbcon.c */
-extern char con2fb_map[MAX_NR_CONSOLES];
+extern signed char con2fb_map[MAX_NR_CONSOLES];
 extern int set_con2fb_map(int unit, int newidx);
 
     /*
-- 
USB is for mice, FireWire is for men!

sUse lINUX ag, nÜRNBERG

^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2004-06-28 19:32 UTC | newest]

Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2004-06-28 19:30 [PATCH] signed bug in drivers/video/console/fbcon.c con2fb_map[] Olaf Hering

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox