public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Russell King <rmk+lkml@arm.linux.org.uk>
To: Andrew Morton <akpm@osdl.org>
Cc: Pat Gefre <pfg@sgi.com>,
	erikj@subway.americas.sgi.com, cw@f00f.org, hch@infradead.org,
	jbarnes@engr.sgi.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2.6] Altix serial driver
Date: Mon, 28 Jun 2004 20:47:07 +0100	[thread overview]
Message-ID: <20040628204707.D9214@flint.arm.linux.org.uk> (raw)
In-Reply-To: <20040628121312.75ac9ed7.akpm@osdl.org>; from akpm@osdl.org on Mon, Jun 28, 2004 at 12:13:12PM -0700

On Mon, Jun 28, 2004 at 12:13:12PM -0700, Andrew Morton wrote:
> Pat Gefre <pfg@sgi.com> wrote:
> >
> > We think we should stick with the major/minor set we have proposed.  We
> >  don't like hacking the 8250 code, dynamic allocation doesn't work (once
> >  that works we will update our driver to use it), registering for our
> >  own major/minor may not work (if we DO get one we will update the
> >  driver to reflect it) but in the meantime we need to get something in
> >  the community that works.
> 
> "we don't like" isn't a very strong argument ;)
> 
> It does sound to me like some work is needed in the generic serial layer to
> teach it to get its sticky paws off the ttyS0 major/minor if there is no
> corresponding hardware.

It isn't that simple.  As I've already pointed out, there is no provision
to do a "maybe hardware exists, maybe it doesn't, lets claim individual
ttys based upon that decision".

It's a restriction of the way the TTY layer is setup to work with the
rest of the kernel, especially the character device layer.

We have these objects called TTY drivers.  They claim a range of TTY
devices, which are attached to a major number, starting at a minimum
minor number, and extending for a certain number of minor numbers.
This marks the complete range of minor numbers as being in use.  This
occurs when a serial driver is registered _well_ before any hardware
is touched.

Separate from that, we register TTY devices for each tty line, maybe
depending on whether hardware exists.  This occurs substantially later
than when the major/minor range is reserved.

> AFAICT nobody has scoped out exactly what has to be done for a clean
> solution there - it may not be very complex.  So could we please
> explore that a little further?

Seriously, the scale of changes required to make this work without
hacks is nontrivial.  If it were trivial, I'd have done it long ago,
since then I wouldn't need /dev/ttyAM, /dev/ttySA, /dev/ttyFB etc
on ARM.

-- 
Russell King
 Linux kernel    2.6 ARM Linux   - http://www.arm.linux.org.uk/
 maintainer of:  2.6 PCMCIA      - http://pcmcia.arm.linux.org.uk/
                 2.6 Serial core

  reply	other threads:[~2004-06-28 19:47 UTC|newest]

Thread overview: 35+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-06-23 14:48 [PATCH 2.6] Altix serial driver Pat Gefre
2004-06-23 15:06 ` Christoph Hellwig
2004-06-23 21:38 ` Andrew Morton
2004-06-23 21:54   ` Jesse Barnes
2004-06-25  3:15     ` Erik Jacobson
2004-06-25  8:31       ` Christoph Hellwig
2004-06-25 12:46         ` Erik Jacobson
2004-06-25 12:48           ` Christoph Hellwig
2004-06-25 13:00             ` Erik Jacobson
2004-06-26 23:52               ` Chris Wedgwood
2004-06-28  0:24                 ` Erik Jacobson
2004-06-28  0:33                   ` Chris Wedgwood
2004-06-28  1:14                     ` Russell King
2004-06-28  1:44                       ` Chris Wedgwood
2004-06-28  7:54                         ` Russell King
2004-06-28  8:14                           ` Chris Wedgwood
2004-06-28  9:02                           ` Russell King
2004-06-28 12:28                           ` Erik Jacobson
2004-06-28 19:04                             ` Pat Gefre
2004-06-28 19:13                               ` Andrew Morton
2004-06-28 19:47                                 ` Russell King [this message]
2004-06-28 20:57                                   ` Andrew Morton
2004-06-28 22:09                                 ` Pat Gefre
2004-06-28 22:20                                   ` Andrew Morton
2004-06-28 23:10                                     ` Russell King
2004-06-25 15:10         ` Jesse Barnes
2004-06-25 15:53           ` Christoph Hellwig
2004-06-25 20:45             ` Andrew Morton
2004-06-25 20:46               ` Christoph Hellwig
  -- strict thread matches above, loose matches on Subject: below --
2004-06-22 16:16 Pat Gefre
2004-06-22 18:24 ` Andrew Morton
2004-06-22 18:36   ` Christoph Hellwig
2004-06-23 14:42     ` Pat Gefre
2004-06-23 15:02       ` Christoph Hellwig
2004-06-23 15:07         ` Erik Jacobson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20040628204707.D9214@flint.arm.linux.org.uk \
    --to=rmk+lkml@arm.linux.org.uk \
    --cc=akpm@osdl.org \
    --cc=cw@f00f.org \
    --cc=erikj@subway.americas.sgi.com \
    --cc=hch@infradead.org \
    --cc=jbarnes@engr.sgi.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=pfg@sgi.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox