Re: [PATCH] Bugfix for CLOCK_REALTIME absolute timer.

[Andrew Morton <akpm@osdl.org>]

George Anzinger <george@mvista.com> wrote:
>
> Ok, I think this does it.

patching file kernel/posix-timers.c
Hunk #10 FAILED at 529.
Hunk #11 succeeded at 776 (offset 18 lines).
Hunk #13 succeeded at 863 (offset 18 lines).
Hunk #15 succeeded at 977 (offset 18 lines).
Hunk #17 succeeded at 1062 (offset 18 lines).
Hunk #19 succeeded at 1435 (offset 18 lines).
1 out of 20 hunks FAILED -- saving rejects to file kernel/posix-timers.c.rej

I fixed that up - please test next -mm, check that it all works?

 +	do {
 +		do {
 +			seq = read_seqbegin(&xtime_lock);
 +			new_wall_to =	wall_to_monotonic;
 +		} while (read_seqretry(&xtime_lock, seq));
 +
 +		spin_lock_irq(&abs_list.lock);
 +		if (list_empty(&cws_list)) {
 +			spin_unlock_irq(&abs_list.lock);
 +			break;
 +		}
 +		timr = list_entry(cws_list.next, struct k_itimer, 
 +				   abs_timer_entry);
 +		
 +		list_del_init(&timr->abs_timer_entry);
 +		if (add_clockset_delta(timr, &new_wall_to) &&
 +		    del_timer(&timr->it_timer))  /* timer run yet? */
 +			add_timer(&timr->it_timer);
 +		list_add(&timr->abs_timer_entry, &abs_list.list);
 +		spin_unlock_irq(&abs_list.lock);
 +	} while (1);

nanonit:

	for ( ; ; ) {
		...
	}

is more readable than

	do {
		...
	} while (1);

because you can see what it's doing as the eye enters the code...