Re: [PATCH] fix different usb-serial oopses for 2.6.7

Zwane Mwaikambo
2004-06-30T04:48:53Z

On Tue, 29 Jun 2004, Greg KH wrote:

> Ok, thanks to both of you posting bug reports that seemed quite
> different, I think I've finally fixed both of your issues. The patch
> below is what I've just added to my trees and will send to Linus in a
> bit, and should solve both problems.
>
> Basically the issue was 2 things:
> - Zwane correctly found that we shouldn't have been calling the
> usb_driver_release_interface() call on disconnect, but if you
> didn't make this call, we leaked memory. This was because of
> the next piece...
> - Harald noticed that if you unloaded a usb-serial driver with
> the device still plugged in, and then removed it, the kernel
> oopsed. He also noticed double calls to the disconnect
> function. This was because we were incorrectly binding the
> device to the usb serial generic driver instead of the one
> that was controlling it.
>
> So, by fixing the usb-serial generic issue, that fixed the fact that we
> shouldn't have been calling the release_interface() call, as it isn't
> necessary (the usb core will take care of it.)
>
> Thanks to everyone for helping out here, and if with this patch, you
> still have problems, please let me know...

Great, thanks Greg, this one works for me.