public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: "David S. Miller" <davem@redhat.com>
To: Ulrich Drepper <drepper@redhat.com>
Cc: linux-kernel@vger.kernel.org
Subject: Re: inconsistency between SIOCGIFCONF and SIOCGIFNAME
Date: Tue, 29 Jun 2004 22:13:41 -0700	[thread overview]
Message-ID: <20040629221341.52824096.davem@redhat.com> (raw)
In-Reply-To: <40E24573.5030403@redhat.com>

On Tue, 29 Jun 2004 21:45:39 -0700
Ulrich Drepper <drepper@redhat.com> wrote:

> When was the netlink interface introduced?  The ioctl() code is most
> probably older and therefore we would still get wrong results on old
> kernels.  I don't know the reason why  you hesitate, but the patch seems
> really harmless and, as you pointed out, more compatible with the BSD
> version.

RTNETLINK interfaces to get link information has existed since at
least 2.0.x or something :-)  In fact, the first RTNETLINK codes
are the ones to obtain and set link information.

All of these BSD ioctls are deprecated interfaces, back compatability
hacks if you real, and the recommended interface to change link and
route information is RTNETLINK.

I really hesitate to change the ioctl() code, because basically my
suggested change puts effectively an AF_UNSPEC address there (this
is what you get with a zero'd out sockaddr_t).  Who knows what that
means.  Sure most apps will ignore it but I absolutely do not want
to take the chance.

This is especially unnecessary since rtnetlink does exactly what you
want already, so we don't need to add a new interface nor change the
semantics of an old one.

  parent reply	other threads:[~2004-06-30  5:14 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-06-29  4:06 inconsistency between SIOCGIFCONF and SIOCGIFNAME Ulrich Drepper
2004-06-29  8:26 ` David S. Miller
2004-06-29 16:22   ` Ulrich Drepper
2004-06-29 19:09   ` Ulrich Drepper
2004-06-29 21:19     ` David S. Miller
2004-06-30  4:45       ` Ulrich Drepper
2004-06-30  5:10         ` YOSHIFUJI Hideaki / 吉藤英明
2004-06-30  5:13         ` David S. Miller [this message]
2004-06-30  7:51           ` Ulrich Drepper
2004-06-30 19:59             ` David S. Miller
2004-06-29 16:32 ` Stephen Hemminger
2004-06-29 19:11   ` Ulrich Drepper

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20040629221341.52824096.davem@redhat.com \
    --to=davem@redhat.com \
    --cc=drepper@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox