public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Russell King <rmk+lkml@arm.linux.org.uk>
To: Pavel Machek <pavel@ucw.cz>
Cc: Linux Kernel List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 2/3] Provide console_suspend() and console_resume()
Date: Wed, 30 Jun 2004 20:30:30 +0100	[thread overview]
Message-ID: <20040630203030.B1496@flint.arm.linux.org.uk> (raw)
In-Reply-To: <20040630123727.GA16409@elf.ucw.cz>; from pavel@ucw.cz on Wed, Jun 30, 2004 at 02:37:29PM +0200

On Wed, Jun 30, 2004 at 02:37:29PM +0200, Pavel Machek wrote:
> Hi!
> 
> > Add console_suspend() and console_resume() methods so the serial drivers
> > can disable console output before suspending a port, and re-enable output
> > afterwards.
> 
> Could it be called console_stop()/console_start()? suspend/resume
> sounds like power managment, and it is unrelated....

It is power management related!  However, we decided that console_start/
console_stop was a better name for it.

That said, it is _NOT_ intended for general use since there is NO
counting of how many times console_stop() is called.  It is merely
used by the serial driver to prevent further serial console output
before shutting the console port down for power management.

This avoids the problem where, on resume, we haven't even enabled
the UART - if we were to attempt to write to the UART in this
circumstance, it would not be setup in any way - no baud rate,
and in fact, since it is disabled, we'd spin for ever waiting for
the port to say its completed transmission of the first byte.

So yes, it most definitely _is_ power management related.

-- 
Russell King
 Linux kernel    2.6 ARM Linux   - http://www.arm.linux.org.uk/
 maintainer of:  2.6 PCMCIA      - http://pcmcia.arm.linux.org.uk/
                 2.6 Serial core

      parent reply	other threads:[~2004-06-30 19:30 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-06-14 14:12 [PATCH 1/3] Provide console_device() Russell King
2004-06-14 14:13 ` [PATCH 2/3] Provide console_suspend() and console_resume() Russell King
2004-06-14 14:13   ` [RFC][PATCH 3/3] Convert console list to list_head Russell King
2004-06-30 12:37   ` [PATCH 2/3] Provide console_suspend() and console_resume() Pavel Machek
2004-06-30 17:32     ` Andrew Morton
2004-06-30 19:30     ` Russell King [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20040630203030.B1496@flint.arm.linux.org.uk \
    --to=rmk+lkml@arm.linux.org.uk \
    --cc=linux-kernel@vger.kernel.org \
    --cc=pavel@ucw.cz \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox