public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Andrey Panin <pazke@donpac.ru>
To: "Leonardo G. Di Lella" <leonardo@dilella.org>
Cc: linux-kernel@vger.kernel.org
Subject: Re: Sony Vaio dmi_scan.c patch!
Date: Thu, 1 Jul 2004 13:43:12 +0400	[thread overview]
Message-ID: <20040701094312.GA8118@pazke> (raw)
In-Reply-To: <40E3F014.1090601@dilella.org>

[-- Attachment #1: Type: text/plain, Size: 1185 bytes --]

On 183, 07 01, 2004 at 11:05:56AM +0000, Leonardo G. Di Lella wrote:
> Hello,
> 
> there is a false entry in the dmi_scan.c while identifing the Sony Vaio.
> 
>    { sony_vaio_laptop, "Sony Vaio", { /* This is a Sony Vaio laptop */
>            MATCH(DMI_SYS_VENDOR, "Sony Corporation"),
>            MATCH(DMI_PRODUCT_NAME, "PCG-"),
>            NO_MATCH, NO_MATCH,
>            } },
> 
> This is the origin part of the kernel (2.6.7). The main problem is that
> this works only with older Vaio (PCG-) models. So the best solution is
> to replace the MATCH(DMI_PRODUCT_NAME, "PCG-") with NO_MATCH,
> because PCG- is referring to a special model and not to all sony vaios.

With this change, it will match all computers made by Sony. Are you 
really sure that they all have Vaio compatible hardware ?

> I have the VGN- model, so the kernel doesnt recognize it as a sony vaio.
> I have replaced the line and now it works. Better change this, for other 
> sony vaio users.
 
New DMI entry will do the same, without risk of false positives.

Best regards.

-- 
Andrey Panin		| Linux and UNIX system administrator
pazke@donpac.ru		| PGP key: wwwkeys.pgp.net

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 189 bytes --]

           reply	other threads:[~2004-07-01  9:43 UTC|newest]

Thread overview: expand[flat|nested]  mbox.gz  Atom feed
 [parent not found: <40E3F014.1090601@dilella.org>]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20040701094312.GA8118@pazke \
    --to=pazke@donpac.ru \
    --cc=leonardo@dilella.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox