From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S264228AbUGBMXu (ORCPT ); Fri, 2 Jul 2004 08:23:50 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S264297AbUGBMXu (ORCPT ); Fri, 2 Jul 2004 08:23:50 -0400 Received: from gprs214-141.eurotel.cz ([160.218.214.141]:49036 "EHLO amd.ucw.cz") by vger.kernel.org with ESMTP id S264228AbUGBMXr (ORCPT ); Fri, 2 Jul 2004 08:23:47 -0400 Date: Fri, 2 Jul 2004 14:20:04 +0200 From: Pavel Machek To: Bartlomiej Zolnierkiewicz Cc: linux-ide@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] ide-taskfile.c fixups/cleanups part #2 [1/9] Message-ID: <20040702122004.GC12889@elf.ucw.cz> References: <200406301724.05862.bzolnier@elka.pw.edu.pl> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <200406301724.05862.bzolnier@elka.pw.edu.pl> X-Warning: Reading this can be dangerous to your mental health. User-Agent: Mutt/1.5.5.1+cvs20040105i Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Hi! > diff -puN drivers/ide/ide-taskfile.c~ide_tf_pio_out_fixes drivers/ide/ide-taskfile.c > --- linux-2.6.7-bk11/drivers/ide/ide-taskfile.c~ide_tf_pio_out_fixes 2004-06-28 21:15:54.030210376 +0200 > +++ linux-2.6.7-bk11-bzolnier/drivers/ide/ide-taskfile.c 2004-06-28 21:15:54.035209616 +0200 > @@ -409,6 +409,10 @@ ide_startstop_t task_out_intr (ide_drive > if (!OK_STAT(stat = hwif->INB(IDE_STATUS_REG), DRIVE_READY, drive->bad_wstat)) { > return DRIVER(drive)->error(drive, "task_out_intr", stat); > } > + > + if (((stat & DRQ_STAT) == 0) ^ !rq->current_nr_sectors) > + return DRIVER(drive)->error(drive, __FUNCTION__, stat); > + Looks pretty close to obfuscated c code contents... Can't you use != or kill ! in second clause and use == or something? Pavel -- People were complaining that M$ turns users into beta-testers... ...jr ghea gurz vagb qrirybcref, naq gurl frrz gb yvxr vg gung jnl!