* [PATCH] Can't open CDROM device for writing
@ 2004-07-01 11:34 Peter Osterlund
2004-07-02 13:26 ` Jens Axboe
0 siblings, 1 reply; 2+ messages in thread
From: Peter Osterlund @ 2004-07-01 11:34 UTC (permalink / raw)
To: Linus Torvalds, Jens Axboe; +Cc: linux-kernel
Opening a CDROM device for writing no longer works, because
cdrom_open() returns -EROFS even if cdrom_open_write() succeeds. This
patch for 2.6.7-bk13 fixes it.
Signed-off-by: Peter Osterlund <petero2@telia.com>
---
linux-petero/drivers/cdrom/cdrom.c | 1 +
1 files changed, 1 insertion(+)
diff -puN drivers/cdrom/cdrom.c~cdrom-write-fix drivers/cdrom/cdrom.c
--- linux/drivers/cdrom/cdrom.c~cdrom-write-fix 2004-07-01 13:16:27.772595136 +0200
+++ linux-petero/drivers/cdrom/cdrom.c 2004-07-01 13:17:34.380469200 +0200
@@ -901,6 +901,7 @@ int cdrom_open(struct cdrom_device_info
goto err;
if (cdrom_open_write(cdi))
goto err;
+ ret = 0;
}
}
_
--
Peter Osterlund - petero2@telia.com
http://w1.894.telia.com/~u89404340
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] Can't open CDROM device for writing
2004-07-01 11:34 [PATCH] Can't open CDROM device for writing Peter Osterlund
@ 2004-07-02 13:26 ` Jens Axboe
0 siblings, 0 replies; 2+ messages in thread
From: Jens Axboe @ 2004-07-02 13:26 UTC (permalink / raw)
To: Peter Osterlund; +Cc: Linus Torvalds, linux-kernel
On Thu, Jul 01 2004, Peter Osterlund wrote:
> Opening a CDROM device for writing no longer works, because
> cdrom_open() returns -EROFS even if cdrom_open_write() succeeds. This
> patch for 2.6.7-bk13 fixes it.
>
> Signed-off-by: Peter Osterlund <petero2@telia.com>
>
> ---
>
> linux-petero/drivers/cdrom/cdrom.c | 1 +
> 1 files changed, 1 insertion(+)
>
> diff -puN drivers/cdrom/cdrom.c~cdrom-write-fix drivers/cdrom/cdrom.c
> --- linux/drivers/cdrom/cdrom.c~cdrom-write-fix 2004-07-01 13:16:27.772595136 +0200
> +++ linux-petero/drivers/cdrom/cdrom.c 2004-07-01 13:17:34.380469200 +0200
> @@ -901,6 +901,7 @@ int cdrom_open(struct cdrom_device_info
> goto err;
> if (cdrom_open_write(cdi))
> goto err;
> + ret = 0;
> }
> }
Indeed, thanks.
--
Jens Axboe
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2004-07-02 13:26 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2004-07-01 11:34 [PATCH] Can't open CDROM device for writing Peter Osterlund
2004-07-02 13:26 ` Jens Axboe
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox